add extra for codex#51
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new “Codex” extra by introducing TextMate .tmTheme theme files for the four Kansō palettes and linking the new extra from the main README.
Changes:
- Add four new TextMate theme files for Codex: Ink, Mist, Pearl, and Zen.
- Define base UI colors plus TextMate scope mappings for common syntax/markup/diff scopes.
- Add an entry in the README “Extras” list pointing to
extras/codex/.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| extras/codex/kanso-ink.tmTheme | New TextMate theme file for the Ink palette. |
| extras/codex/kanso-mist.tmTheme | New TextMate theme file for the Mist palette. |
| extras/codex/kanso-pearl.tmTheme | New TextMate theme file for the Pearl palette. |
| extras/codex/kanso-zen.tmTheme | New TextMate theme file for the Zen palette. |
| README.md | Adds a link in the Extras list to the new Codex directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <string>Invalid / Deprecated</string> | ||
| <key>scope</key> | ||
| <string>invalid, invalid.deprecated, markup.deleted.git_gutter</string> | ||
| <key>settings</key> |
There was a problem hiding this comment.
The “Invalid / Deprecated” rule includes the scope markup.deleted.git_gutter, which is unrelated to invalid/deprecated tokens and can cause Git gutter deletions to inherit the invalid styling (e.g., strikethrough/gray). Consider removing markup.deleted.git_gutter from this rule and, if needed, adding a dedicated rule for git_gutter scopes.
| <string>Diff Added</string> | ||
| <key>scope</key> | ||
| <string>markup.inserted, markup.inserted.diff, meta.diff.header.from-file</string> | ||
| <key>settings</key> | ||
| <dict> | ||
| <key>foreground</key> | ||
| <string>#6E915F</string> | ||
| <key>background</key> | ||
| <string>#B7D0AE</string> | ||
| </dict> | ||
| </dict> | ||
|
|
||
| <dict> | ||
| <key>name</key> | ||
| <string>Diff Removed</string> | ||
| <key>scope</key> | ||
| <string>markup.deleted, markup.deleted.diff, meta.diff.header.to-file</string> | ||
| <key>settings</key> |
There was a problem hiding this comment.
The diff header scopes look swapped: meta.diff.header.from-file is grouped under “Diff Added” and meta.diff.header.to-file under “Diff Removed”. Typically “from-file” corresponds to deletions and “to-file” to additions; consider swapping these (or removing the header scopes from these rules) so headers match the correct diff side.
| <string>Invalid / Deprecated</string> | ||
| <key>scope</key> | ||
| <string>invalid, invalid.deprecated, markup.deleted.git_gutter</string> | ||
| <key>settings</key> |
There was a problem hiding this comment.
The “Invalid / Deprecated” rule includes the scope markup.deleted.git_gutter, which is unrelated to invalid/deprecated tokens and can cause Git gutter deletions to inherit the invalid styling (e.g., strikethrough/gray). Consider removing markup.deleted.git_gutter from this rule and, if needed, adding a dedicated rule for git_gutter scopes.
| <string>Diff Added</string> | ||
| <key>scope</key> | ||
| <string>markup.inserted, markup.inserted.diff, meta.diff.header.from-file</string> | ||
| <key>settings</key> | ||
| <dict> | ||
| <key>foreground</key> | ||
| <string>#76946A</string> | ||
| <key>background</key> | ||
| <string>#2B3328</string> | ||
| </dict> | ||
| </dict> | ||
|
|
||
| <dict> | ||
| <key>name</key> | ||
| <string>Diff Removed</string> | ||
| <key>scope</key> | ||
| <string>markup.deleted, markup.deleted.diff, meta.diff.header.to-file</string> | ||
| <key>settings</key> |
There was a problem hiding this comment.
The diff header scopes look swapped: meta.diff.header.from-file is grouped under “Diff Added” and meta.diff.header.to-file under “Diff Removed”. Typically “from-file” corresponds to deletions and “to-file” to additions; consider swapping these (or removing the header scopes from these rules) so headers match the correct diff side.
| <string>Invalid / Deprecated</string> | ||
| <key>scope</key> | ||
| <string>invalid, invalid.deprecated, markup.deleted.git_gutter</string> | ||
| <key>settings</key> |
There was a problem hiding this comment.
The “Invalid / Deprecated” rule includes the scope markup.deleted.git_gutter, which is unrelated to invalid/deprecated tokens and can cause Git gutter deletions to inherit the invalid styling (e.g., strikethrough/gray). Consider removing markup.deleted.git_gutter from this rule and, if needed, adding a dedicated rule for git_gutter scopes.
| <string>Diff Added</string> | ||
| <key>scope</key> | ||
| <string>markup.inserted, markup.inserted.diff, meta.diff.header.from-file</string> | ||
| <key>settings</key> | ||
| <dict> | ||
| <key>foreground</key> | ||
| <string>#76946A</string> | ||
| <key>background</key> | ||
| <string>#2B3328</string> | ||
| </dict> | ||
| </dict> | ||
|
|
||
| <dict> | ||
| <key>name</key> | ||
| <string>Diff Removed</string> | ||
| <key>scope</key> | ||
| <string>markup.deleted, markup.deleted.diff, meta.diff.header.to-file</string> | ||
| <key>settings</key> |
There was a problem hiding this comment.
The diff header scopes look swapped: meta.diff.header.from-file is grouped under “Diff Added” and meta.diff.header.to-file under “Diff Removed”. Typically “from-file” corresponds to deletions and “to-file” to additions; consider swapping these (or removing the header scopes from these rules) so headers match the correct diff side.
| <key>name</key> | ||
| <string>Invalid / Deprecated</string> | ||
| <key>scope</key> | ||
| <string>invalid, invalid.deprecated, markup.deleted.git_gutter</string> |
There was a problem hiding this comment.
The “Invalid / Deprecated” rule includes the scope markup.deleted.git_gutter, which is unrelated to invalid/deprecated tokens and can cause Git gutter deletions to inherit the invalid styling (e.g., strikethrough/gray). Consider removing markup.deleted.git_gutter from this rule and, if needed, adding a dedicated rule for git_gutter scopes.
| <string>invalid, invalid.deprecated, markup.deleted.git_gutter</string> | |
| <string>invalid, invalid.deprecated</string> |
| <string>Diff Added</string> | ||
| <key>scope</key> | ||
| <string>markup.inserted, markup.inserted.diff, meta.diff.header.from-file</string> | ||
| <key>settings</key> | ||
| <dict> | ||
| <key>foreground</key> | ||
| <string>#76946A</string> | ||
| <key>background</key> | ||
| <string>#2B3328</string> | ||
| </dict> | ||
| </dict> | ||
|
|
||
| <dict> | ||
| <key>name</key> | ||
| <string>Diff Removed</string> | ||
| <key>scope</key> | ||
| <string>markup.deleted, markup.deleted.diff, meta.diff.header.to-file</string> | ||
| <key>settings</key> |
There was a problem hiding this comment.
The diff header scopes look swapped: meta.diff.header.from-file is grouped under “Diff Added” and meta.diff.header.to-file under “Diff Removed”. Typically “from-file” corresponds to deletions and “to-file” to additions; consider swapping these (or removing the header scopes from these rules) so headers match the correct diff side.
|
Codex 0.105.0 has now been released! https://github.com/openai/codex/releases |
Summary
extras/codex/with Kanso Ink, Mist, Pearl, and Zen.tmThemefilesNotes
xmllintfor all four files0.105.0(Control over color theme in TUI openai/codex#1618)