Skip to content

i18n: Improve zh-CN localization & fix Simplified Chinese label glyph#726

Open
Xiaocaihassome wants to merge 2 commits into
webadderallorg:mainfrom
Xiaocaihassome:feat/zh-CN-translation
Open

i18n: Improve zh-CN localization & fix Simplified Chinese label glyph#726
Xiaocaihassome wants to merge 2 commits into
webadderallorg:mainfrom
Xiaocaihassome:feat/zh-CN-translation

Conversation

@Xiaocaihassome

@Xiaocaihassome Xiaocaihassome commented Jul 5, 2026

Copy link
Copy Markdown

While using Recordly on Windows, I found multiple flawed points in Simplified Chinese localization.
The language dropdown uses wrong Traditional glyph "簡體中文" instead of standard Simplified writing, fixed in MorePopover.tsx and SettingsPanel.tsx.
Many UI areas lack complete zh-CN localized text and fall back to raw English, including click effect configs, zoom blur parameters, caption editor buttons, preset & theme panels, project brow
ser, unsaved changes pop-up and timeline toolbar.
I refined zh-CN locale entries inside settings.json, editor.json and shortcuts.json, and added matching base English keys to support further language expansion.
Full local test finished on Windows 11. UI screenshots and code diffs are attached below.
image
image
image
image
image
image
image
image
image
屏幕截图_5-7-2026_212639_github com

Summary by CodeRabbit

  • Localization / UI Text Updates
    • Added and expanded translated labels across the editor and settings, including projects, export status (success + “show in folder”), timeline controls, presets, theme selection, and unsaved-changes prompts.
    • Enhanced Chinese settings text for motion/visual effects, cursor click effects presets, improved captions editor labels/actions, and additional background/video upload messaging.
    • Updated Simplified Chinese language naming and localized the “Frame” header in the settings UI.
  • New Features
    • Added fixed shortcut/label mappings for annotation cycling, delete selected, pan, and zoom.

@github-actions github-actions Bot added the Slop label Jul 5, 2026
@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

⚠️ This pull request has been flagged by Anti-Slop.
Our automated checks detected patterns commonly associated with
low-quality or automated/AI submissions (failure count reached).
No automatic closure — a maintainer will review it.
If this is legitimate work, please add more context, link issues, or ping us.

@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a7bb82f9-9ba5-4e43-b870-73b2da68ab3e

📥 Commits

Reviewing files that changed from the base of the PR and between 127b626 and 3666129.

📒 Files selected for processing (1)
  • src/components/video-editor/SettingsPanel.tsx
✅ Files skipped from review due to trivial changes (1)
  • src/components/video-editor/SettingsPanel.tsx

📝 Walkthrough

Walkthrough

This PR updates zh-CN label text in two components and expands editor, shortcuts, and settings locale strings in English and zh-CN.

Changes

Locale label and translation expansion

Layer / File(s) Summary
zh-CN label updates
src/components/launch/popovers/MorePopover.tsx, src/components/video-editor/SettingsPanel.tsx
LOCALE_LABELS and APP_LANGUAGE_LABELS switch zh-CN text to simplified Chinese, and the Frame section header uses a settings translation fallback.
Editor locale expansion
src/i18n/locales/en/editor.json, src/i18n/locales/zh-CN/editor.json
Editor locale files add project, export status, timeline, recordings folder, presets, theme, unsaved-changes, and common strings, with a boundary adjustment in the annotations block.
Shortcuts fixed labels
src/i18n/locales/en/shortcuts.json, src/i18n/locales/zh-CN/shortcuts.json
Shortcuts locale files add a top-level fixed section for cycle annotation, delete, and pan/zoom labels.
zh-CN settings locale expansion
src/i18n/locales/zh-CN/settings.json
Settings locale adds effect and padding controls, captions editor labels, background upload text, and settings section navigation labels.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: Checked

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers purpose, motivation, screenshots, and testing, but it doesn't follow the template or include explicit Type of Change, Related Issues, or Checklist sections. Rewrite it using the repository template and add the missing sections, especially Type of Change, Related Issue(s), Testing Guide, and Checklist.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: zh-CN localization improvements and the Simplified Chinese label glyph fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

⚠️ This pull request has been flagged by Anti-Slop.
Our automated checks detected patterns commonly associated with
low-quality or automated/AI submissions (failure count reached).
No automatic closure — a maintainer will review it.
If this is legitimate work, please add more context, link issues, or ping us.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
src/i18n/locales/zh-CN/settings.json (1)

286-295: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Remove the unused settingsSections block. The settings UI only reads sections.*, so this locale-only copy will just drift over time.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/i18n/locales/zh-CN/settings.json` around lines 286 - 295, Remove the
unused settingsSections locale block from the zh-CN settings JSON, since the
settings UI reads sections.* instead. Update the locale entry in settings.json
by deleting the settingsSections object and keep the remaining translation keys
aligned with the structure used by the settings UI.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/components/video-editor/SettingsPanel.tsx`:
- Line 2517: The frame label JSX in SettingsPanel is missing the closing brace
for the tSettings call, making the span invalid. Update the label expression in
the frame section so the translation function call is properly closed before the
closing span tag, and verify the surrounding JSX in SettingsPanel renders
cleanly.

---

Nitpick comments:
In `@src/i18n/locales/zh-CN/settings.json`:
- Around line 286-295: Remove the unused settingsSections locale block from the
zh-CN settings JSON, since the settings UI reads sections.* instead. Update the
locale entry in settings.json by deleting the settingsSections object and keep
the remaining translation keys aligned with the structure used by the settings
UI.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4c4f6849-7f9f-406a-a19d-204e81967430

📥 Commits

Reviewing files that changed from the base of the PR and between 641d223 and 127b626.

📒 Files selected for processing (7)
  • src/components/launch/popovers/MorePopover.tsx
  • src/components/video-editor/SettingsPanel.tsx
  • src/i18n/locales/en/editor.json
  • src/i18n/locales/en/shortcuts.json
  • src/i18n/locales/zh-CN/editor.json
  • src/i18n/locales/zh-CN/settings.json
  • src/i18n/locales/zh-CN/shortcuts.json

Comment thread src/components/video-editor/SettingsPanel.tsx Outdated
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

⚠️ This pull request has been flagged by Anti-Slop.
Our automated checks detected patterns commonly associated with
low-quality or automated/AI submissions (failure count reached).
No automatic closure — a maintainer will review it.
If this is legitimate work, please add more context, link issues, or ping us.

1 similar comment
@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

⚠️ This pull request has been flagged by Anti-Slop.
Our automated checks detected patterns commonly associated with
low-quality or automated/AI submissions (failure count reached).
No automatic closure — a maintainer will review it.
If this is legitimate work, please add more context, link issues, or ping us.

@Xiaocaihassome

This comment was marked as duplicate.

@Xiaocaihassome

Copy link
Copy Markdown
Author

⚠️这个拉取请求已被Anti-Slop标记。我们的自动检查检测出了与低质量或自动化/人工智能提交常见相关的模式(达到失败计数)。没有自动关闭——维护者会审核。如果这是正规工作,请补充更多背景、链接问题或联系我们。

This PR is a fully manual Simplified Chinese localization improvement for Recordly, not auto-generated AI spam.
I found incomplete zh-CN UI texts and wrong Traditional Chinese glyph on language dropdown when using the software on Windows, then manually sorted all unlocalized entries one by one.
I edited settings.json, editor.json, shortcuts.json and two TSX component files line by line to add missing translation keys and fix hard-coded Chinese characters. Paid translation AI was only used for auxiliary proofreading; every line of text was manually adjusted to fit the software UI context.
The previous branch was discarded because translation content failed to submit completely, this PR is a brand-new rewrite with fresh code changes and newly captured screenshots.
Full local verification finished on Windows 11. All code diff screenshots and UI preview screenshots are attached in PR description for manual review.
This is legitimate open-source feature optimization work, please remove the Anti-Slop flag after manual inspection.
Closes #725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant