Fix pre-testing review findings: legal attribution, security hardening, UX bugs

.github/workflows/homebrew-tap.yml

@@ -22,7 +22,7 @@ jobs:
     env:
       GH_TOKEN: ${{ secrets.HOMEBREW_TAP_TOKEN }}
       TAP_REPO: ${{ github.event.inputs.tap_repo || vars.HOMEBREW_TAP_REPO || 'webadderall/homebrew-tap' }}
-      AUTO_MERGE_TAP_PR: ${{ vars.HOMEBREW_TAP_AUTO_MERGE || 'true' }}
+      AUTO_MERGE_TAP_PR: ${{ vars.HOMEBREW_TAP_AUTO_MERGE || 'false' }}
     steps:
       - name: Validate token
         run: |

.github/workflows/release.yml

@@ -371,18 +371,33 @@ jobs:
         with:
           python-version: '3.11'
 
-      - name: Configure Windows signing
+      - name: Validate Windows signing secrets
         shell: pwsh
         env:
           WINDOWS_SIGNING_CERTIFICATE_P12_BASE64: ${{ secrets.WINDOWS_SIGNING_CERTIFICATE_P12_BASE64 }}
           WINDOWS_SIGNING_CERTIFICATE_PASSWORD: ${{ secrets.WINDOWS_SIGNING_CERTIFICATE_PASSWORD }}
         run: |
-          if ([string]::IsNullOrWhiteSpace($env:WINDOWS_SIGNING_CERTIFICATE_P12_BASE64) -or [string]::IsNullOrWhiteSpace($env:WINDOWS_SIGNING_CERTIFICATE_PASSWORD)) {
-            Write-Warning 'Windows signing secrets are missing. Building an unsigned installer.'
-            Add-Content -Path $env:GITHUB_ENV -Value 'CSC_IDENTITY_AUTO_DISCOVERY=false'
-            exit 0
+          $missing = @()
+          foreach ($name in 'WINDOWS_SIGNING_CERTIFICATE_P12_BASE64', 'WINDOWS_SIGNING_CERTIFICATE_PASSWORD') {
+            $value = [Environment]::GetEnvironmentVariable($name)
+            if ([string]::IsNullOrWhiteSpace($value)) {
+              $missing += $name
+            }
           }
 
+          if ($missing.Count -gt 0) {
+            foreach ($name in $missing) {
+              Write-Error "Missing required Windows release secret: $name"
+            }
+            exit 1
+          }
+
+      - name: Configure Windows signing
+        shell: pwsh
+        env:
+          WINDOWS_SIGNING_CERTIFICATE_P12_BASE64: ${{ secrets.WINDOWS_SIGNING_CERTIFICATE_P12_BASE64 }}
+          WINDOWS_SIGNING_CERTIFICATE_PASSWORD: ${{ secrets.WINDOWS_SIGNING_CERTIFICATE_PASSWORD }}
+        run: |
           $certPath = Join-Path $env:RUNNER_TEMP 'windows-signing-cert.p12'
           [IO.File]::WriteAllBytes($certPath, [Convert]::FromBase64String($env:WINDOWS_SIGNING_CERTIFICATE_P12_BASE64))
           Add-Content -Path $env:GITHUB_ENV -Value "WIN_CSC_LINK=$certPath"

CONTRIBUTING.md

@@ -49,7 +49,7 @@ Areas where help is especially valuable:
 
 ## Reporting Issues
 
-If you encounter a bug or have a feature request, please open an issue in the [Issues](https://github.com/webadderallorg/Recordly/issues) section of this repository. Provide as much detail as possible to help us address the issue effectively.
+If you encounter a bug or have a feature request, please open an issue in the [Issues](https://github.com/Alfredoalv13/Recordly/issues) section of this repository. Provide as much detail as possible to help us address the issue effectively.
 
 ## Style Guide
 
@@ -58,6 +58,6 @@ If you encounter a bug or have a feature request, please open an issue in the [I
 
 ## License
 
-By contributing to this project, you agree that your contributions will be licensed under the [MIT License](./LICENSE).
+By contributing to this project, you agree that your contributions will be licensed under the [GNU Affero General Public License v3.0](./LICENSE.md), matching the project's actual license (this repo is an AGPLv3 fork of Recordly; it is not MIT-licensed).
 
 Thank you for your contributions!