Improve selectedcontent parsing update for select multiple#60193
Merged
Conversation
When a selected option element is done parsing, it triggers an update to the selectedcontent element of the associated select element. In the case of a select element with the multiple attribute, this could result in many clones if multiple options have the selected attribute. This change improves this by moving the selectedcontent update for select elements with the multiple attribute from option end tag parsing to select end tag parsing. Context: whatwg/html#12430 (comment) Bug: 483769482 Change-Id: I9ee8a2afe66884da26cbf814b80af7bf430414a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7856275 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1636613}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7856275
branch
from
d8cc4db to
0dc4755
Compare
wpt-pr-bot
approved these changes
May 27, 2026
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a selected option element is done parsing, it triggers an update to
the selectedcontent element of the associated select element. In the
case of a select element with the multiple attribute, this could result
in many clones if multiple options have the selected attribute.
This change improves this by moving the selectedcontent update for
select elements with the multiple attribute from option end tag parsing
to select end tag parsing.
Context: whatwg/html#12430 (comment)
Bug: 483769482
Change-Id: I9ee8a2afe66884da26cbf814b80af7bf430414a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7856275
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1636613}