Remove compute_from from features without comments#4079
Open
ddbeck wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
feature definition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic transformation of existing
compute_fromto compat sets. This is the "easy" set where there are no comments that need moving around. It should not modify any statuses (evidenced by no changes to dist files).The main consequence of this PR is to ratchet previously ignored keys (those not in
compute_fromlists) into the strictest subset of keys available that does not change the feature's overall status (e.g., intocorefor keys that match the status ofcompute_fromkeys).