Add feature for responsive iframes#4077
Conversation
Elchi3
left a comment
There was a problem hiding this comment.
Description looks great to me! Just two thoughts on expected keys.
| # compat_features: | ||
| # - css.properties.frame-sizing | ||
| # - css.properties.frame-sizing.auto | ||
| # - css.properties.frame-sizing.content-width |
There was a problem hiding this comment.
C.f. https://collector.openwebdocs.org/tests/css/properties/frame-sizing
| # - css.properties.frame-sizing.content-width | |
| # - css.properties.frame-sizing.content-height | |
| # - css.properties.frame-sizing.content-width |
| # - css.properties.frame-sizing.content-width | ||
| # - css.properties.frame-sizing.content-block-size | ||
| # - css.properties.frame-sizing.content-inline-size | ||
| # - api.Window.requestResize |
There was a problem hiding this comment.
Maybe also this?
| # - api.Window.requestResize | |
| # - api.Window.requestResize | |
| # - html.elements.meta.name.responsive-embedded-sizing |
| spec: https://drafts.csswg.org/css-sizing-4/#propdef-frame-sizing | ||
| # Expected | ||
| # compat_features: | ||
| # - css.properties.frame-sizing |
There was a problem hiding this comment.
Question for @ddbeck: The linked spec in the feature here mentions the frame's "internal intrinsic size"—would this warrant linking the min-content and max-content CSS keywords in this feature? I'm referring specifically to the intrinsic size concept, as it figures in pretty heavily here for <iframe> contents.
On the other side, I suppose it could be argued that you'd then have to add references for these keywords to many features' compat_features field.
Adds a feature for responsive iframes with the
frame-sizingCSS property,<meta name="responsive-embedded-sizing">element, andwindow.requestResize()API.Fixes #4036.