Skip to content

declare npm as the package manager (refs #598) - #4

Open
yakimoto wants to merge 1 commit into
mainfrom
fix/598-declare-npm
Open

declare npm as the package manager (refs #598)#4
yakimoto wants to merge 1 commit into
mainfrom
fix/598-declare-npm

Conversation

@yakimoto

@yakimoto yakimoto commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

This repo declared no packageManager, so which manager it uses was a guess. Part of the
wave-av/claude-workstation#598 sweep.

npm here is DECLARED, not inferred

There was genuinely no evidence either way — no lockfile, no docs naming a manager, and no
install step in CI at all
. The one npm line that shows up across the fleet is the governance
bootstrap:

npm install @wave-av/governance@^0.4.4 --no-save --no-audit --no-fund

That is the governance tool installing itself with --no-save. It says nothing about how a
project installs its own dependencies, and treating it as evidence is how two pnpm repos nearly
got a package-lock.json earlier in this sweep. So this is a decision, now written into the
manifest so nobody has to guess again.

Why there is no lockfile in this PR

This package.json declares zero dependencies. A package-lock.json here would contain only
the root entry — it would pin nothing and review as noise. #598's ask was "commit the lockfile,"
but a lockfile is only meaningful once there is a tree to lock.

The moment a real dependency is added, npm install will produce one against the manager this PR
just made explicit — which is the part that actually needed deciding.

⚠️ CI cannot run — the org is on plan: free and Actions has returned startup_failure for every
run since 2026-07-27.

Refs wave-av/claude-workstation#598

🤖 Generated with Claude Code


View with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is enabled.


Note

Cursor Bugbot is generating a summary for commit 0a1ffd1. Configure here.


Summary by cubic

Declare packageManager as npm@10.9.2 to make the repo’s package manager explicit and remove guesswork (aligns with #598).
No lockfile is added because there are no dependencies; one will be generated by npm install when a dependency is introduced.

Written for commit 0a1ffd1. Summary will update on new commits.

Review in cubic

This repo declared no `packageManager` field, so which manager it uses was a guess.
wave-av/claude-workstation#598 tracked that across 8 repos. There was no evidence either way
here — no lockfile, no docs naming a manager, and no install step in CI. The one npm line
that appears across the fleet is the governance bootstrap
(`npm install @wave-av/governance --no-save`), which is the governance tool installing
itself and says nothing about how a project installs its own dependencies.

So npm is DECLARED rather than inferred, and written into the manifest so it never has to be
guessed again.

No lockfile is added, deliberately: this package.json declares ZERO dependencies, so a
lockfile would contain only the root entry and pin nothing. It becomes worth generating the
moment a real dependency is added — at which point `npm install` will produce one against
the manager this commit just made explicit.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0a1ffd1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cursor

cursor Bot commented Jul 29, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_fae72485-73e7-4e9a-b31b-e225c99e429e)

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 31 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3ac24256-00bc-41fb-a15d-d667909683ce

📥 Commits

Reviewing files that changed from the base of the PR and between a4676d6 and 0a1ffd1.

📒 Files selected for processing (1)
  • package.json

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant