fix(action): show the cubit logo in the no-data fallback comment#2
Merged
Conversation
The fallback comment (posted when compare finds no benchmark output) used a plain "## cubit — performance" header, unlike the normal report which carries the logo. Match report.go's header so every cubit PR comment shows the logo, consistent with bulwark. Claude-Session: https://claude.ai/code/session_016pTq6aVBJvTtXmwTgKw2Yh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The action's fallback comment (posted when
cubit comparefinds no benchmark output) used a plain## cubit — performanceheader, while the normal report (report.go) carries the logo via a raw-URL<img>. This was visible on wardnet#972, where there are no benches yet.Match
report.go's header so every cubit PR comment shows the logo, consistent with bulwark.Merge Commit Message
fix(action): show the cubit logo in the no-data fallback comment
The fallback comment now uses the same logo header as report.go, so every cubit PR comment is branded consistently.
https://claude.ai/code/session_016pTq6aVBJvTtXmwTgKw2Yh