[truealpha-datahub] Implement strict Yahoo adapter - #186
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR advances the D3 “staging TOPT capture” batch by landing an E0-only, unregistered Yahoo Chart adapter slice (strict JSON/Decimal parsing + frozen call plan) and updating governance metadata to reflect E0 acceptance and an E1 target, while keeping the batch explicitly non-activated (no persistence/scheduling/release binding).
Changes:
- Update D3 batch governance metadata (manifest + Vision issue graph) to accept E0 and advance the target rung to E1.
- Add an E0 Yahoo Chart slice (
e0_slice.py) that freezes request plans and parses Yahoo Chart JSON intoDecimalwithout binary floats, with strict fail-closed validation. - Add a targeted pytest suite covering frozen corpus binding, strict parsing failure modes, and mocked HTTP behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| governance/vision-issue-graph.json | Advances D3-staging-topt-capture status/target rung and updates pinned manifest SHA. |
| governance/evidence/D3-staging-topt-capture-E0.v1.json | Adds D3 E0 rung evidence artifact (currently schema/head-SHA issues noted in review comments). |
| governance/batches/D3-staging-topt-capture.v1.json | Accepts E0 in the batch manifest, advances target to E1, and records accepted output metadata. |
| apps/data-engine/tests/batches/staging_topt_capture/test_e0_slice.py | Adds focused unit tests for the frozen plan + strict Yahoo parsing and mocked HTTP call. |
| apps/data-engine/src/data_engine/batches/staging_topt_capture/e0_slice.py | Implements the strict Yahoo Chart adapter slice and corpus/plan binding utilities for E0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wangzitian0
force-pushed
the
batch/d3-e0-code
branch
from
July 14, 2026 12:46
1120982 to
bb38e9d
Compare
wangzitian0
force-pushed
the
batch/d3-e0-code
branch
from
July 14, 2026 12:47
bb38e9d to
d90024b
Compare
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Acceptance evidence
4fdc70fe5fb7a18da3c9a0f28c0b10ba49553990and headd90024b1666c0a6bf2b8cd0c2d1609c5c65671f6Claim ceiling
This accepts isolated E0 configuration/parser behavior only. It makes no persisted-capture, live-source readiness, Staging, scheduling, strategy, Production, or release-readiness claim.
Advances #171.