Skip to content

[truealpha-datahub] Implement strict Yahoo adapter - #186

Merged
wangzitian0 merged 5 commits into
mainfrom
batch/d3-e0-code
Jul 14, 2026
Merged

[truealpha-datahub] Implement strict Yahoo adapter#186
wangzitian0 merged 5 commits into
mainfrom
batch/d3-e0-code

Conversation

@wangzitian0

@wangzitian0 wangzitian0 commented Jul 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • add an unregistered, batch-private Yahoo chart source configuration and content-addressed frozen call plan
  • parse raw JSON numeric tokens directly to Decimal and fail closed on identity, date, exchange, OHLCV, schema, status, and content-type drift
  • retain adjusted close as reconciliation-only and factor-invisible while preserving unadjusted OHLCV
  • accept only D3 E0 and advance the canonical target to E1; no persistence, schedule, live Staging run, or release activation is added

Acceptance evidence

  • targeted D3 E0 suite: 28 passed
  • targeted Ruff and full mypy: passed (91 source files)
  • offline issue graph, live GitHub parity, and pull-request authorization passed
  • exact current base 4fdc70fe5fb7a18da3c9a0f28c0b10ba49553990 and head d90024b1666c0a6bf2b8cd0c2d1609c5c65671f6
  • Delivery Governance generates strict RungEvidence against the final PR head during CI; no self-referential checked-in evidence is claimed

Claim ceiling

This accepts isolated E0 configuration/parser behavior only. It makes no persisted-capture, live-source readiness, Staging, scheduling, strategy, Production, or release-readiness claim.

Advances #171.

Copilot AI review requested due to automatic review settings July 14, 2026 12:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR advances the D3 “staging TOPT capture” batch by landing an E0-only, unregistered Yahoo Chart adapter slice (strict JSON/Decimal parsing + frozen call plan) and updating governance metadata to reflect E0 acceptance and an E1 target, while keeping the batch explicitly non-activated (no persistence/scheduling/release binding).

Changes:

  • Update D3 batch governance metadata (manifest + Vision issue graph) to accept E0 and advance the target rung to E1.
  • Add an E0 Yahoo Chart slice (e0_slice.py) that freezes request plans and parses Yahoo Chart JSON into Decimal without binary floats, with strict fail-closed validation.
  • Add a targeted pytest suite covering frozen corpus binding, strict parsing failure modes, and mocked HTTP behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
governance/vision-issue-graph.json Advances D3-staging-topt-capture status/target rung and updates pinned manifest SHA.
governance/evidence/D3-staging-topt-capture-E0.v1.json Adds D3 E0 rung evidence artifact (currently schema/head-SHA issues noted in review comments).
governance/batches/D3-staging-topt-capture.v1.json Accepts E0 in the batch manifest, advances target to E1, and records accepted output metadata.
apps/data-engine/tests/batches/staging_topt_capture/test_e0_slice.py Adds focused unit tests for the frozen plan + strict Yahoo parsing and mocked HTTP call.
apps/data-engine/src/data_engine/batches/staging_topt_capture/e0_slice.py Implements the strict Yahoo Chart adapter slice and corpus/plan binding utilities for E0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread governance/evidence/D3-staging-topt-capture-E0.v1.json Outdated
Comment thread governance/evidence/D3-staging-topt-capture-E0.v1.json Outdated
@wangzitian0
wangzitian0 merged commit 146ff58 into main Jul 14, 2026
14 checks passed
@wangzitian0
wangzitian0 deleted the batch/d3-e0-code branch July 15, 2026 03:52
@wangzitian0 wangzitian0 changed the title [truealpha-data] [D3:E0] Implement strict Yahoo adapter [truealpha-datahub] Implement strict Yahoo adapter Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants