[truealpha-factors] Freeze Qlib selection adapter oracle - #184
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Transitions the S7 “issuer strategy selection” batch from queued → prepared by freezing a checked-in tiny corpus that specifies the engine-independent Decimal selection oracle (and the pinned Qlib execution binding metadata) for later adapter implementation, while updating delivery governance metadata to reflect the corrected ownership boundary (#26 owns execution).
Changes:
- Adds the S7 twelve-candidate corpus fixture defining the selection frame, expected ranking/selection, negative controls, and determinism controls.
- Updates the S7 batch manifest to revision 2 and status prepared, pins
activation.base_sha, pins the corpus path+sha256, and updates objective/claim ceiling/requirements to match the new Qlib-adapter ownership split. - Updates the Vision issue graph entry for S7 to reflect the prepared status and new manifest SHA-256.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| libs/factors/tests/batches/issuer_strategy_selection_tiny/fixtures/corpus.v1.json | Introduces the frozen tiny corpus spec for the S7 engine-independent Decimal oracle and Qlib binding metadata. |
| governance/vision-issue-graph.json | Marks S7 as prepared and updates the pinned manifest SHA-256 in the Vision graph. |
| governance/batches/S7-issuer-strategy-selection.v1.json | Advances the batch manifest to revision 2 / prepared, pins base SHA + corpus hash, and records corrected ownership and additional fail-closed controls. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+50
to
+61
| "engine_binding": { | ||
| "distribution": "pyqlib", | ||
| "version": "0.9.7", | ||
| "release_commit": "da920b7f954f48ab1bb64117c976710de198373e", | ||
| "adapter_id": "truealpha.qlib-selection-adapter.v1", | ||
| "operator_registry_id": "truealpha.qlib-operators.v1", | ||
| "strategy_id": "large_model_value_full_rebalance_top_n.v1", | ||
| "strategy_semantics": "full_rebalance_top_n", | ||
| "builtin_topk_dropout_is_equivalent": false, | ||
| "score_transport": "decimal_string_to_float64_after_strict_order_validation", | ||
| "runtime_artifact_hash": "required-at-execution" | ||
| }, |
Comment on lines
+149
to
+163
| "positive_case": { | ||
| "case_id": "twelve-candidate-eleven-eligible-top-ten", | ||
| "valuation_results": [ | ||
| { | ||
| "public_candidate_id": "candidate-01", | ||
| "availability": "available", | ||
| "tier": "large_model_native", | ||
| "target_ps_lower": "20", | ||
| "target_ps_upper": "30", | ||
| "target_ps_midpoint": "25", | ||
| "current_price_to_sales": "10", | ||
| "valuation_gap": "1.5", | ||
| "confidence": "0.99", | ||
| "reason_codes": [] | ||
| }, |
wangzitian0
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyqlib==0.9.7and record adapter, operator-registry, strategy, score-transport, and runtime-artifact identitiesScope
This is a preparation transition only:
queued -> prepared. It earns no evidence rung, installs no dependency, and adds no runtime adapter. The implementation revision must merge PR #182 first, pin the exact dependency lock, and obtain a shared-path lease.Validation
make issue-graph-checkgit diff --checkTracks #181.