Refactor to add set_tigris_year() and incorporate validate_ functions#205
Open
elipousson wants to merge 23 commits into
Open
Refactor to add set_tigris_year() and incorporate validate_ functions#205elipousson wants to merge 23 commits into
set_tigris_year() and incorporate validate_ functions#205elipousson wants to merge 23 commits into
Conversation
- Revise state/county checks to use new `require_` and `multiple` parameters - Add `set_tigris_year` to reduce duplicate code + improve validation - Add `year_suffix()` helper function for readability - Add `match_resolution()` function - Replace calls to stop w/ cli_abort + message w/ cli_inform - Remove .data operator (deprecated in tidyselect 1.2.0) - Minor style clean-up
Unnecessary after prefixing fips_code
Reorganize test for enumeration units by function
Also swap email for Eli Pousson
`theme_void()` is equivalent to `ggthemes::theme_map()` so dropped ggthemes from examples
Issue due to removal of .data
Add test for new_england error
Simplify `check_tigris_year()` by removing function name from message and dropping "To request this feature, file an issue" suggestion Add `not_year` argument to exclude years between min/max values
Remove duplicative check for year < 1990 (couldn't be triggered) Remove call to cli_abort w/ no message (for years 2001-2009
Revert change to set_tigris_year message
Relocate match_resolution function to calls w/ cb = TRUE
Remove repetitive calls to local_options
Drop tidycensus from Suggests
Also add tests for list_states, filter_state, and grep_state
Contributor
Author
|
Hey @walkerke! It has been a while but I pushed a couple updates to this PR so it works with the latest version of roxygen. I also swapped cli_inform for cli_bullets so the message can be suppressed by suppressMessages. Let me know if do anything else to prep this for review. |
Owner
|
Thanks! I'll dig in soon. As an FYI - tigris is going to go through a full modernization this summer so I'll be weaving a lot of your work into that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are the changes focused on continued improvements to validation
require_andmultipleparametersset_tigris_yearto reduce duplicate code + improve validationyear_suffix()helper function for readabilitymatch_resolution()functioncheck_cb()function to validate cb argumentOther related clean-up changes include:
theme_mapw/theme_void