Derive PUMS recode_years from pums_variables (remove hard-coding)#636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Closes #634
load_data.Rcurrently hard-codes the year range used to determine whether PUMS recoding is supported (viarecode_years <- ...). This PR derives the supported years directly from the packagedpums_variablesdataset (scoped to the requestedsurvey), so adding new PUMS dictionaries doesn’t require updating code inload_data.R.No intended behavior changes beyond removing the manual maintenance step.
Why
pums_variablesalready contains the authoritative list ofsurvey/yearcombinations with dictionaries (and thus recode support). Using it eliminates the need to updaterecode_yearsannually.Tests I ran
acs1recode works (labels returned):Result includes
STATE_labelandSEX_labelcolumns.acs1currently does not recode on main (expected until dictionary update):Result shows the current message:
(With this PR, the supported-year check is no longer hard-coded and will automatically reflect the years present in
pums_variablesonce 2024 is added.)Notes
acs1dictionary support.