Skip to content

Editorial: CORE-AAM small fixes#2808

Merged
spectranaut merged 2 commits into
mainfrom
aamtest-remove-window-interface
Jun 11, 2026
Merged

Editorial: CORE-AAM small fixes#2808
spectranaut merged 2 commits into
mainfrom
aamtest-remove-window-interface

Conversation

@spectranaut

@spectranaut spectranaut commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Netlify Preview:
🔄 this PR updates the following sspecs:

Editorial:

  • Makes clear that an interface is an ATK interface, not ATSPI
  • Corrects a typo in a role name.

@spectranaut spectranaut added editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo spec:core-aam labels Jun 5, 2026
@netlify

netlify Bot commented Jun 5, 2026

Copy link
Copy Markdown

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 6c94771
🔍 Latest deploy log https://app.netlify.com/projects/wai-aria/deploys/6a234341c16c990008cac0f9
😎 Deploy Preview https://deploy-preview-2808--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://deploy-preview-2808--wai-aria.netlify.app

@github-actions github-actions Bot temporarily deployed to pull request June 5, 2026 01:35 Inactive
@spectranaut

Copy link
Copy Markdown
Contributor Author

@joanmarie -- for some reason, in Core-AAM, both the alertdialog and dialog mention a "window" interface.. which does not seem to exist in the Atspi: https://docs.gtk.org/atspi2/class.Accessible.html

And also your old manual tests don't mention it... so I'm guess it doesn't exist and it's a mistake that it was ever included, but I thought I'd check with you just in case :)

@joanmarie

joanmarie commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

@joanmarie -- for some reason, in Core-AAM, both the alertdialog and dialog mention a "window" interface.. which does not seem to exist in the Atspi: https://docs.gtk.org/atspi2/class.Accessible.html

It exists in ATK: https://docs.gtk.org/atk/iface.Window.html, but as you found not in AT-SPI.

AT-SPI listens for the ATK events and passes (most of) them to assistive technologies. See this code.

And also your old manual tests don't mention it... so I'm guess it doesn't exist and it's a mistake that it was ever included, but I thought I'd check with you just in case :)

My old manual tests don't mention it because they come from the AT-SPI side.

Having said that, this Chromium code suggests that there's not a Chromium implementation. I think Gecko does implement it. And I have no idea about WebKitGTK.

EDIT: Please see my next comment in which I clarify the above.

This is a long way of saying: I'm honestly not sure what you should do. 😁 I'd have to give it some more thought, test Orca with various ARIA alerts and dialogs, and ponder what the ideal solution is. I can add that to my TODO list...

@joanmarie

Copy link
Copy Markdown
Contributor

I really should drink more energy drinks before submitting comments....

The Chromium code from my previous comment, combined with this other Chromium code which I forgot to include in my previous comment, suggests that there's not a Chromium implementation for the ARIA roles.

And my Gecko and WebKitGTK comments were also about the ARIA roles; not about the native browser window.

@spectranaut

spectranaut commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Ahhh thanks @joanmarie awesome, that is so helpful. Once the new aam tests can test events I guess we will be able to test if the window interface is implemented by testing for events...? I'm also going to make a to do to look into this later.

And for now I'll update this PR to specify it is an ATK interface, somehow.

Edit: Made issue for adding tests w3c/core-aam#260

@spectranaut spectranaut marked this pull request as draft June 5, 2026 18:13
@spectranaut spectranaut marked this pull request as ready for review June 5, 2026 21:44
@spectranaut spectranaut force-pushed the aamtest-remove-window-interface branch from f7e8de3 to 6c94771 Compare June 5, 2026 21:44
@spectranaut spectranaut changed the title Editorial: CORE-AAM small fixes (remove reference, and fix type) Editorial: CORE-AAM small fixes Jun 5, 2026
@github-actions github-actions Bot temporarily deployed to pull request June 5, 2026 21:45 Inactive
@spectranaut spectranaut requested a review from cyns June 5, 2026 21:48
@spectranaut

Copy link
Copy Markdown
Contributor Author

@cyns can you review this one?

@spectranaut spectranaut merged commit 634ac89 into main Jun 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo spec:core-aam

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants