Editorial: CORE-AAM small fixes#2808
Conversation
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
🚀 Deployed on https://deploy-preview-2808--wai-aria.netlify.app |
|
@joanmarie -- for some reason, in Core-AAM, both the alertdialog and dialog mention a "window" interface.. which does not seem to exist in the Atspi: https://docs.gtk.org/atspi2/class.Accessible.html And also your old manual tests don't mention it... so I'm guess it doesn't exist and it's a mistake that it was ever included, but I thought I'd check with you just in case :) |
It exists in ATK: https://docs.gtk.org/atk/iface.Window.html, but as you found not in AT-SPI. AT-SPI listens for the ATK events and passes (most of) them to assistive technologies. See this code.
My old manual tests don't mention it because they come from the AT-SPI side. Having said that, this Chromium code suggests that there's not a Chromium implementation. I think Gecko does implement it. And I have no idea about WebKitGTK. EDIT: Please see my next comment in which I clarify the above. This is a long way of saying: I'm honestly not sure what you should do. 😁 I'd have to give it some more thought, test Orca with various ARIA alerts and dialogs, and ponder what the ideal solution is. I can add that to my TODO list... |
|
I really should drink more energy drinks before submitting comments.... The Chromium code from my previous comment, combined with this other Chromium code which I forgot to include in my previous comment, suggests that there's not a Chromium implementation for the ARIA roles. And my Gecko and WebKitGTK comments were also about the ARIA roles; not about the native browser window. |
|
Ahhh thanks @joanmarie awesome, that is so helpful. Once the new aam tests can test events I guess we will be able to test if the window interface is implemented by testing for events...? I'm also going to make a to do to look into this later. And for now I'll update this PR to specify it is an ATK interface, somehow. Edit: Made issue for adding tests w3c/core-aam#260 |
f7e8de3 to
6c94771
Compare
|
@cyns can you review this one? |
🚀 Netlify Preview:
🔄 this PR updates the following sspecs:
Editorial: