Skip to content

feat: add aria-checked support to gridcell and row#2390

Open
smhigley wants to merge 4 commits into
mainfrom
gridcell-aria-checked
Open

feat: add aria-checked support to gridcell and row#2390
smhigley wants to merge 4 commits into
mainfrom
gridcell-aria-checked

Conversation

@smhigley

@smhigley smhigley commented Dec 3, 2024

Copy link
Copy Markdown
Contributor

🚀 Netlify Preview:
🔄 this PR updates the following sspecs:

Closes #1960

Adds aria-checked as a supported state to gridcell, with the same wording around combining aria-checked & aria-selected as on option and treeitem. The aria-checked support also inherits into columnheader and rowheader.

Test, Documentation and Implementation tracking

Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.


Preview | Diff

@netlify

netlify Bot commented Dec 3, 2024

Copy link
Copy Markdown

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit fcede88
🔍 Latest deploy log https://app.netlify.com/projects/wai-aria/deploys/69d759c502e6fd00084e83d5
😎 Deploy Preview https://deploy-preview-2390--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@adampage adampage left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a persuasive and easy-to-describe use case where all of those extremely rare conditions are sufficiently satisfied? 😅 If so, how about offering it in a note?

Otherwise, this LGTM! 🚀

@smhigley

smhigley commented Dec 5, 2024

Copy link
Copy Markdown
Contributor Author

Is there a persuasive and easy-to-describe use case where all of those extremely rare conditions are sufficiently satisfied? 😅 If so, how about offering it in a note?

Heh, my personal opinion is still that aria-checked and aria-selected never belong on the same node together. That debate happened a while ago though, and the current wording (borrowed from option and treeitem) is the result 🤪

@smhigley smhigley changed the title feat: add aria-checked support to gridcell feat: add aria-checked support to gridcell and row Dec 9, 2024

@hidde hidde left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@jnurthen jnurthen removed the request for review from hidde-logius December 19, 2024 18:23
@jnurthen

Copy link
Copy Markdown
Member

@mcking65 can you please review

@pkra pkra force-pushed the gridcell-aria-checked branch from ddc6426 to 28461ba Compare March 7, 2025 17:16
@pkra

pkra commented Mar 7, 2025

Copy link
Copy Markdown
Member

@smhigley rebased on main. I hope I didn't do any damage.

@front-endian front-endian left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; really clear and easy to understand!

(Despite having seen some complex tables where this could be used, I really hope people respect the "extremely rare" part of this. 😅)

@spectranaut spectranaut moved this from Needs Review to Reviewed, other needs in ARIA Normative PR Tracking Aug 26, 2025
@spectranaut

Copy link
Copy Markdown
Contributor

Needs bugs on browsers.

@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://deploy-preview-2390--wai-aria.netlify.app

@github-actions github-actions Bot temporarily deployed to pull request April 9, 2026 07:49 Inactive
@HaTheo

HaTheo commented Jun 3, 2026

Copy link
Copy Markdown

Issue filed for Mozilla: https://bugzilla.mozilla.org/show_bug.cgi?id=2044549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Reviewed, other needs

Development

Successfully merging this pull request may close these issues.

Consider supporting aria-checked on gridcells

8 participants