fix: handle non-string note attributes in note_hash computation#134
Open
yaniv-golan wants to merge 1 commit intovzhd1701:masterfrom
Open
fix: handle non-string note attributes in note_hash computation#134yaniv-golan wants to merge 1 commit intovzhd1701:masterfrom
yaniv-golan wants to merge 1 commit intovzhd1701:masterfrom
Conversation
When ENEX note-attributes contain nested XML elements, the parser returns dicts instead of strings. Calling .encode() on a dict crashes with AttributeError. Coerce to str() before encoding. Fixes vzhd1701#111
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
note-attributescontain nested XML elements, the parser returns dicts instead of stringsnote_hashcalls.encode("utf-8")on each field, which crashes withAttributeError: 'dict' object has no attribute 'encode'str()before encodingFixes #111
Test plan