fix: avoid getPublicPageData for spaceId during file upload#132
Open
yaniv-golan wants to merge 1 commit intovzhd1701:masterfrom
Open
fix: avoid getPublicPageData for spaceId during file upload#132yaniv-golan wants to merge 1 commit intovzhd1701:masterfrom
yaniv-golan wants to merge 1 commit intovzhd1701:masterfrom
Conversation
The getPublicPageData endpoint returns 500 for private pages, causing all file uploads to fail. Use client.current_space.id instead, which is already available from the initial auth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_upload_filecallsnew_block.space_info["spaceId"]to get the space ID for file uploadsspace_infouses thegetPublicPageDataAPI endpoint, which returns 500 for private pagesHTTPError: 500 Server Errorclient.current_space.idinstead, which is already available from initial authenticationTest plan