fix: handle Notion attachment URL format in file upload#131
Open
yaniv-golan wants to merge 1 commit intovzhd1701:masterfrom
Open
fix: handle Notion attachment URL format in file upload#131yaniv-golan wants to merge 1 commit intovzhd1701:masterfrom
yaniv-golan wants to merge 1 commit intovzhd1701:masterfrom
Conversation
Notion now returns attachment:UUID:filename URLs instead of S3 URLs for uploaded files. This caused all notes with file attachments to fail with "Uploaded file URL format changed".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
attachment:UUID:filenameURLs instead of S3 URLs for uploaded files_extract_file_idonly handled the old AWS S3 URL format, causing all notes with file attachments to fail withValueError: Uploaded file URL format changedattachment:URL format while keeping backwards compatibility with S3 URLsTest plan
test_upload_url_parser_attachmentfor the new URL format