fix: prevent duplicate pages on upload retry#130
Open
yaniv-golan wants to merge 1 commit intovzhd1701:masterfrom
Open
fix: prevent duplicate pages on upload retry#130yaniv-golan wants to merge 1 commit intovzhd1701:masterfrom
yaniv-golan wants to merge 1 commit intovzhd1701:masterfrom
Conversation
Each retry attempt was creating a new Notion page, leaving N duplicate [UNFINISHED UPLOAD] pages. Now the page is created once and reused across retries, with children cleared before each retry attempt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[UNFINISHED UPLOAD]pages for N retry attemptsupload_noteinto focused functions:create_note_page,upload_note_blocks,remove_note_page,clear_page_children[UNFINISHED UPLOAD]and cleanup respects--keep-failedTest plan
tests/test_retry_dedup.pycovering page reuse, child clearing, keep-failed behavior, DB mode, and cleanup failures