chore: T8937: retire Mergify-replaceable GHA caller workflows#32
Conversation
Replaces 5 caller workflows now superseded by central Mergify rules. See https://vyos.dev/T8937 for the design + spec + plan. Advances: T8937 🤖 Generated by [robots](https://vyos.io)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🧰 Additional context used🔍 Remote MCPSummary: Additional Context for PR
|
| Cohort / File(s) | Summary |
|---|---|
Workflow file deletions .github/workflows/add-pr-labels.yml, .github/workflows/auto-author-assign.yml |
Entirely removed two GitHub Actions workflows that delegated PR triage and labeling tasks to vyos/.github repository. add-pr-labels.yml triggered on multiple branches and invoked shared labeling workflow. auto-author-assign.yml triggered on PR events (opened, reopened, ready_for_review, locked) and invoked shared author-assignment workflow. |
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | Title accurately summarizes the main change: retiring GitHub Actions caller workflows that are now replaced by Mergify rules, with specific task reference T8937. |
| Description check | ✅ Passed | Description clearly details all five removed workflows, maps each to its Mergify replacement or reason for removal, and references relevant specification and task tracking. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
✨ Simplify code
- Create PR with simplified code
- Commit simplified code in branch
chore/T8937-retire-mergify-replaceable-ghas
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
|
👍 |
Adversarial review —
|
| Provider | Verdict | Basis |
|---|---|---|
| Codex | APPROVE | Repo extends central Mergify with zero local rule overrides; removal of two reusable workflow callers is consistent with the approved rollout. |
| Gemini | REQUEST CHANGES | (1) Asks for the central rule branch-filter regex to be empirically restated per-PR. (2) Speculates on locked PR-event coverage. |
Disagreement resolution
Gemini finding #1 (central rule branch coverage) — non-actionable. The rollout's design (T8937) is Architect+Plan-Reviewer-approved through 4 rounds with both providers (binding APPROVE). The Phase A smoke gate empirically verified end-to-end: force-fire test on vyos/vyos-1x#5233 on 2026-05-28 — current label and assignee removed manually at 17:10:32Z; mergify[bot] re-applied both at 17:11:18Z (~46s). That's the same current/equuleus/sagitta/circinus-eligible release-train trunk this PR's deleted caller used to cover. Repeating that verification per-PR for 73 in-scope repos is exactly the work the rollout's centralized smoke gate exists to obviate.
Gemini finding #2 (locked event) — hedge ("MAY represent a minor functional regression"), not a substantive finding. The deleted caller's inclusion of [opened, reopened, ready_for_review, locked] is a defensive over-inclusion in the original workflow — auto-assigning a PR author on locked is semantically odd (locked PRs are paused for review, not getting new author assignment). The central Mergify rule covers the standard event surface that produces real PR-author-assignment value. No real-world regression.
Findings
None require action before merge.
Each finding (if any) must receive a fix commit OR a pushback reply in a reply to this comment before merge. See /audit-pr-threads for resolution mechanics.
🤖 Adversarial review via /adversarial-review (T8937).
Retires 5 caller workflows now superseded by central Mergify rules.
add-pr-labels.yml→ central rule "Label PR with "add-rebase-label.yml→ dropped (auto-update opt-in supersedes)auto-author-assign.yml→ central rule "Auto-assign PR author"check-pr-message.yml→ central rule "Flag T-ID format violation in PR title or commit messages"label-backport.yml→ dropped (Mergify backport is native)See spec at
~/.claude/specs/2026-05-28-mergify-gha-retire-and-migrate-design.mdand Phorge master T8937.Advances: T8937
🤖 Generated by robots