fix: support no-default-features builds - #158
Merged
Merged
Conversation
Signed-off-by: DefiAudit0x <1.17640355e+08+DefiAudit0x@users.noreply.github.com>
Signed-off-by: DefiAudit0x <1.17640355e+08+DefiAudit0x@users.noreply.github.com>
vyncint
approved these changes
Aug 23, 2026
This was referenced Aug 24, 2026
vyncint
added a commit
that referenced
this pull request
Aug 24, 2026
#158 turned main red on a pull request in which every commit was signed off. Its branch carried a merge commit ("sync branch with upstream main"), and GitHub composes the squash message from the commits it squashes -- except that a merge commit among them makes it emit an empty body. The trailers went with it, so 471df02 landed carrying no Signed-off-by, and check-dco.sh failed the push. That failure is unfixable after the fact: main is linear history, non-fast-forward, and protect-main has no bypass actors. The commit is immutable and the run stays red over a policy that was met. Checked against every merged PR here: the three other multi-commit PRs (#153, #142, #137) all had non-merge commits only and all kept their trailers; #158 is the only branch containing a merge commit and the only empty body. Enabling web_commit_signoff_required is not an answer -- a probe on a scratch branch showed GitHub neither appends a sign-off nor refuses the commit for API-created commits. So name the one commit that GitHub composed -- the tip of a push to main, passed as github.event.after -- and exempt only that, and only when it looks like a squash merge (web-flow committer, subject ending "(#123)", no sign-off at all). It reports a ::notice::, not silence. Everything else keeps the strict sign-off==author check, pull_request runs exempt nothing, and a contributor cannot reach the exemption: being the tip of a push to main means having gone through a pull request that already passed. Verified against 471df02 itself (fails unnamed, passes named, still fails when a different or bogus sha is named), against the squash merges that were already fine, and against synthetic web-flow commits with and without a PR number. CONTRIBUTING now says to rebase rather than merge when updating a branch, which is what main's linear history wants anyway and avoids the trigger. Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes #143.
The crate-level snapshot doctests referenced
insta-gated APIs unconditionally, socargo test --workspace --no-default-featuresfailed even thoughinstais documented as optional. The CI workflow also did not exercise that supported configuration.This change keeps the doctest entry points valid without
instaby placing the snapshot calls behind#[cfg(feature = "insta")]blocks. It also adds a dedicatedno-default-featuresCI job and makesrequired-greenwait for it, preventing this configuration from regressing unnoticed.Checklist
Linked an issue (
Closes #143)Tests added/updated for the change (the affected doctest now exercises both feature configurations)
cargo fmt --allandcargo clippy --workspace --all-targets --all-featuresare cleancargo test --workspace --no-default-featurespassescargo test --workspace --all-featurespassescargo doc --no-deps --all-featurespasses withRUSTDOCFLAGS=-D warningscargo check --workspace --lockedpassesAll commits are signed off (
git commit -s)No AI attribution trailers are present
CHANGELOG.mdnot updated; this is a developer-facing CI and doctest correctness fixNo snapshot changes
Notes
The baseline failure was reproduced before the fix:
cargo test --workspace --no-default-featuresreported 20 passing tests and 1 failing doctest. The final verification passed after the fix. The branch contains one signed-off commit and changes onlycrates/termlens/src/lib.rsand.github/workflows/ci.yml.