fix: line up the columns in the two messages that offer a way out - #72
Merged
Conversation
Both are first-run paths, and both are what somebody reads when mossaic has just refused to do the thing they asked for. `could not detect a GitHub user` listed three ways forward with one of them two columns out of line, and put `--demo` last — the only one of the three that needs no account, no network and no decision, which makes it the one to lead with. The missing-file message was mine, from an hour ago, and it tried to align a column against an interpolated path. That cannot work: the path is however long the reader typed. It also repeated the path back inside the suggestion, where it was noise — they know what they typed; what they need is the shape of the command. `FILE` says that and lines up. Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both are first-run paths — what somebody reads when mossaic has just refused to do what they asked.
could not detect a GitHub userhad one of its three suggestions two columns out of line, and listed--demolast. That is the only one of the three needing no account, no network and no decision, so it now comes second, right after charting someone by name.The missing-file message is one I added earlier today, and it tried to align a column against an interpolated path — which cannot work, since the path is however long the reader typed. It also echoed the path back inside the suggestion, where it was noise.
FILEsays the shape of the command and lines up:Folded into the
[0.6.3]changelog section, which is not tagged yet.Checklist
tests/chart_cli.rs, which asserts the message names the file and offers both routes; 213 tests passcargo fmt --allandcargo clippy --workspace --all-targets --all-featuresare cleanCHANGELOG.mdupdated