Skip to content

fix: Clean up awkward user-facing tune/config output lines - #27

Open
VedantMadane wants to merge 2 commits into
vyncint:mainfrom
VedantMadane:fix/issue-25
Open

fix: Clean up awkward user-facing tune/config output lines#27
VedantMadane wants to merge 2 commits into
vyncint:mainfrom
VedantMadane:fix/issue-25

Conversation

@VedantMadane

Copy link
Copy Markdown

Summary

Clean up awkward user-facing tune/config output lines

Changes

  • Remove stray spaces in ESTIMATED tuning header line

Fixes #25

- Remove stray spaces in ESTIMATED tuning header line

Fixes vyncint#25

Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>

@vyncint vyncint left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up — both string changes are correct, and the sweep is complete: there is no user-facing (s) left anywhere in crates/.

Three things before it can land, and the first two are quick.

1. Two stray files. COMMITMSG and PRBODY.md are in the diff at the repo root. They look like local scratch files for composing the commit message and PR body — git rm them and they are gone.

2. The goldens need re-blessing — this is why the four checks are red. app.rs now emits configuration, but overview-80x24.txt and overview-110x32.txt still record configuration(s):

assertion `left == right` failed: overview: frame differs from golden overview-80x24.txt
-  │1 REFUSED configuration(s) measured FASTER than the chosen one — view 3       │
+  │1 REFUSED configuration measured FASTER than the chosen one — view 3          │

One command, and I ran it against your branch to be sure of what it does:

LAUNCHBOUND_BLESS=1 cargo test -p launchbound-tui --test tui

It changes exactly those two lines in those two files, and the suite then passes 6/6. Please read the diff before committing it, the way tests/tui.rs asks — blessing without looking is how a golden ends up recording a bug.

3. Optional, and genuinely not a blocker. The else branch is never exercised: the only fixture (run-flip) produces exactly one rejected-faster candidate, so "configurations" is unreached by any test. If adding a second one to the fixture is easy, it would cover both sides. If it turns out to be fiddly, leave it — I would rather not turn a two-line fix into a fixture project.

On the line-splitting I floated in #25: it was optional and the header reads fine as it is now. No need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Two lines of output that read as bugs: stray spaces in the tune header, and configuration(s)

2 participants