test: termlens 0.6.1, for the openpty retry - #14
Merged
Merged
Conversation
0.6.0 fails on macOS when the machine is briefly out of PTY devices -- the kernel has not finished recycling one and openpty returns ENXIO. The retry that fixes it was merged into termlens and left unreleased for two days, so every consumer on 0.6.0 still had it, this one included. It shows up as one red shard in ten on a sixteen-core Mac, which is the kind of failure that gets re-run rather than diagnosed. mossaic hit it during a release and that is how it was traced. launchbound-tui is the only crate that uses termlens, and its six PTY tests are the ones this affects. They pass. 41 tests across the workspace, fmt and clippy clean. No release follows. Nothing under crates/ has changed since v1.2.0 except this dev-dependency, and cargo install ignores dev-dependencies -- so a version bump would deliver nothing to anyone. Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
termlens 0.6.0 fails on macOS when the machine is briefly out of PTY devices — the kernel has not finished recycling one and
openptyreturnsENXIO.The retry that fixes it was merged into termlens and left unreleased for two days, so every consumer on 0.6.0 still had the bug. It surfaces as one red shard in ten on a sixteen-core Mac — the kind of failure that gets re-run rather than diagnosed. mossaic hit it mid-release, which is how it was traced.
launchbound-tuiis the only crate here that uses termlens, and its six PTY tests are exactly what this affects. They pass. 41 tests across the workspace, fmt and clippy clean.No release follows, deliberately
Nothing under
crates/has changed since v1.2.0 except this dev-dependency:cargo installignores dev-dependencies, so a version bump would deliver nothing to anyone — it would burn a version number on a test-harness change. Same conclusion as reconverge, for the same reason.