Start the heart on ground that is still clean - #7
Merged
Conversation
Tracking the merged plan against the live graph rather than against a fixture found two things. The picture opened with a hole. Column 34 is the week this plan was made in, today already had ten contributions on it, and a heart's top-left corner is dark -- so the very first cell was a day that must stay dark and already could not. Nothing takes a contribution away, so it would have reported `holed` from the first run to the last, which is the exact failure the VYNCINT plan died of. It starts at column 35 now: the first column still entirely in the future. The outer columns were dead weight. The leftmost and rightmost columns of a 13-wide heart are entirely dark, so they constrained fourteen days to stay dark for no drawing at all. Trimmed, the picture is eleven columns and the must-stay-dark count falls from 35 to 21. It runs Sunday 30 August to 14 November: 56 days at 35 contributions, 1,960 in total, verdict reachable, no holes. The same run also found a reporting bug in mossaic, fixed in 0.6.1 and published: a day outside the picture was being told to stay dark, which would have been every day from 15 November onward. Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking the merged plan against the live graph rather than a fixture found two things.
The picture opened with a hole
Column 34 is the week this plan was made in. Today already had ten contributions on it, and a heart's top-left corner is dark — so the very first cell was a day that must stay dark and already could not. Nothing takes a contribution away, so it would have reported
holedfrom the first run to the last: the exact failure the VYNCINT plan died of (#3).It starts at column 35 now — the first column still entirely in the future.
The outer columns were dead weight
The leftmost and rightmost columns of the 13-wide heart were entirely dark, constraining fourteen days to stay dark for no drawing at all. Trimmed to eleven columns, the must-stay-dark count falls from 35 to 21.
reachable, no holesIt also found a bug in mossaic
The same run reported
today must stay darkfor a day outside the picture — which would have been every day from 15 November onward. Both a covered-but-dark day and an uncovered day have aneedof zero, and the tracker read the number rather than the intent. Fixed in mossaic 0.6.1, published, and verified here: