Follow mossaic 0.6.0, and verify a picture as well as text - #5
Merged
Conversation
The action gained template, matrix and image inputs. This repository is where it meets a real contribution graph, so it is where the new path should be exercised -- and the claim worth checking is not that pictures work, it is that they run the *same* assertions unchanged. Two matrix cases draw the dragon template instead of text, on a busy year and a quiet one. Every existing assertion applies to them untouched: the thirteen flat outputs are still re-derived from the same JSON report, the documented enumerations still hold, and field-days is still zero when no field is drawn. If the generalisation had leaked, one of them would say so here rather than in somebody's Slack six weeks from now. background and top are left at their defaults on purpose. The action refuses both with a picture, so a case that passed them would be testing the refusal rather than the drawing. Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mossaic 0.6.0 is published, and the action gained
template,matrixandimageinputs.Both workflows move to
@v0.6.0, andverify.ymlgains two cases that draw the dragon template instead of text — on a busy year and a quiet one.The claim worth checking is not that pictures work. It is that they run the same assertions unchanged: the thirteen flat outputs re-derived from the same JSON report, the documented enumerations, and
field-dayszero when no field is drawn. A picture is the same plan underneath, so if that generalisation had leaked, one of these says so here rather than in somebody's Slack six weeks from now.backgroundandtopstay at their defaults deliberately — the action refuses both with a picture, so a case that passed them would be testing the refusal rather than the drawing.