Follow mossaic 0.5.0, and verify the action rather than only using it - #2
Merged
Conversation
The tracker was pinned to the v0.2.0 action while mossaic is at 0.5.0. The input surface is unchanged between them, so this is a ref bump plus the two things mossaic's own track.example.yml grew since the copy was taken: the comment gate, and the documented version input. The gate matters more than it looks. Commenting on the tracking issue every day, including days that need nothing, turns it into a feed you stop reading -- which is the one failure mode a reminder cannot survive. It now comments only when today is actually short. Adds verify.yml, which is the part that makes this a testing repository rather than a consumer. track.yml runs one plan once a day and can only ever prove that plan still works. verify.yml runs four -- a field and none, a non-default top row, a year with nothing in it -- and re-derives every one of the thirteen flat outputs from the same JSON report with the expression the action itself uses. The twenty output values are plumbing that rots quietly when a field is renamed, and nothing in mossaic's own tests can see it. Documented enumerations and the legibility thresholds are checked too. Always the published crate from crates.io, never a sibling build, and uncached: a green run has to mean what a user installs today works. Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tracker was pinned to the v0.2.0 action while mossaic is at 0.5.0. The input surface is identical between the two, so the upgrade is a ref bump plus the two things mossaic's own
track.example.ymlgrew since this copy was taken.track.yml
vyncint/mossaic/action@v0.2.0→@v0.5.0.if: steps.art.outputs.today-short != '0'on the issue comment. Commenting every day, including days that need nothing, turns the tracking issue into a feed you stop reading — the one failure mode a reminder cannot survive.versioninput, left onlatestdeliberately: following the newest published release is the point of this repository.verify.yml — new
track.ymlruns one plan once a day, so it can only ever prove that plan still works.verify.ymlruns four (a field and none, a non-default top row, a year with nothing in it) and checks the report against itself:jsonoutput with the same jq expression the action uses. Those twentyvalue:expressions are plumbing that rots quietly when a field is renamed, and nothing in mossaic's own test suite can see it.verdict∈ drawn/reachable/holed,legibility∈ clear/readable/faint).field-levelis an input echoed back, so a mismatch is plumbing by definition; and no field drawn must mean no field days owed.separation.Runs weekly, on dispatch, and on
repository_dispatch(tool-published) so a mossaic release can trigger it. Always the published crate from crates.io, uncached.Both jq paths and thresholds were checked against a real report before writing the assertions, not inferred from the action source.
Also
The standard
commit-policyworkflow and its two scripts, matching the four tool repos.