Mark M1 done in AGENTS.md/CLAUDE.md - #115
Merged
Merged
Conversation
|
The doc still read "M1 is still open: #23, #24, #25" after all three merged and closed epic #18. Replaced the stale line with a writeup matching the file's existing density: what each PR actually built, the client-secret-vs-private_key_jwt schema conflict caught and resolved in permission-literal bug Lightbridge caught in #24, and #25's two-genuinely- separate-OS-processes acceptance gate. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
stephane-segning
force-pushed
the
claude/ticket-filtering-773c5c
branch
from
August 3, 2026 14:14
577de59 to
898ce72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENTS.md(CLAUDE.mdsymlinks to it) — status line for Milestone 1 changed from "in progress" to "done," and the stale "M1 is still open: Service-account provisioning (provisionAppClient) #23, RBAC layers 1 and 2 #24, Gate: a persisted client_credentials client gets a token #25" line replaced with a writeup of what each of those three PRs actually built.Intent
#23/#24/#25merged as #111/#112/#113, closing epic #18 (M1 — sms-auth). The project-context doc every session reads first still said M1 was open and named those three issues as outstanding, which would mislead the next session into re-scoping already-finished work. Source of truth: #111, #112, #113, and epic #18 (all closed).Scope
Documentation only, one file. Adds three paragraphs matching the file's existing density (specific file/line references, what was found and how, not just what shipped):
#23: the schema's ownProvisionClientResult.clientSecretand the issue's own text both predated theprivate_key_jwt-only decision and still described a shared-secret flow — caught by cross-checkingsms-auth/src/lib.rs's existingclient_secret_hash: Nonehardcode before any implementation started. Documents the resolution (server-generated RSA keypair, private key returned once, only the public JWK persisted) and what was explicitly cut (retirement/overlap-window rotation).#24: Layer 1 regression tests, the new Layer 2 primitive (require_permission), and theprovider:write->provider:updatepermission-literal bug Lightbridge's review caught before merge (the literal matched nothing in §5.2's actual vocabulary).#25: the two-genuinely-separate-OS-processes acceptance gate, and the one documented, reasoned deviation from the issue's literal wording (provisioning via direct procedure call rather than HTTP, since no real token in this deployment can carry theowner/adminroleprovisionAppClientrequires).Verification
Documentation-only change — no code paths affected.
mainand epic Epic: M1 — sms-auth: OIDC, service accounts, RBAC #18 is closed before writing "M1 closed" (gh issue view/gh pr viewagainst the live repo, not assumed).main(AGENTS.mduntouched by any intervening commit), no conflicts.Screenshots/Evidence
N/A — prose-only documentation change, no UI surface.
Risk Assessment
None. Doc-only, additive, no code or schema touched.
AI Usage Declaration
This PR was written by Claude Code (Claude Sonnet 5) under my direction, summarizing work from the same session that implemented and landed #111/#112/#113 (which I reviewed and merged myself).
Reviewer Focus
Whether the M1 writeup is pitched at the right level of detail for this file's existing style — dense enough to be useful, not so long it drowns the next section.