Skip to content

Mark M1 done in AGENTS.md/CLAUDE.md - #115

Merged
stephane-segning merged 1 commit into
mainfrom
claude/ticket-filtering-773c5c
Aug 3, 2026
Merged

Mark M1 done in AGENTS.md/CLAUDE.md#115
stephane-segning merged 1 commit into
mainfrom
claude/ticket-filtering-773c5c

Conversation

@stephane-segning

Copy link
Copy Markdown
Contributor

Summary

Intent

#23/#24/#25 merged as #111/#112/#113, closing epic #18 (M1 — sms-auth). The project-context doc every session reads first still said M1 was open and named those three issues as outstanding, which would mislead the next session into re-scoping already-finished work. Source of truth: #111, #112, #113, and epic #18 (all closed).

Scope

Documentation only, one file. Adds three paragraphs matching the file's existing density (specific file/line references, what was found and how, not just what shipped):

  • #23: the schema's own ProvisionClientResult.clientSecret and the issue's own text both predated the private_key_jwt-only decision and still described a shared-secret flow — caught by cross-checking sms-auth/src/lib.rs's existing client_secret_hash: None hardcode before any implementation started. Documents the resolution (server-generated RSA keypair, private key returned once, only the public JWK persisted) and what was explicitly cut (retirement/overlap-window rotation).
  • #24: Layer 1 regression tests, the new Layer 2 primitive (require_permission), and the provider:write -> provider:update permission-literal bug Lightbridge's review caught before merge (the literal matched nothing in §5.2's actual vocabulary).
  • #25: the two-genuinely-separate-OS-processes acceptance gate, and the one documented, reasoned deviation from the issue's literal wording (provisioning via direct procedure call rather than HTTP, since no real token in this deployment can carry the owner/admin role provisionAppClient requires).

Verification

Documentation-only change — no code paths affected.

Screenshots/Evidence

N/A — prose-only documentation change, no UI surface.

Risk Assessment

None. Doc-only, additive, no code or schema touched.

AI Usage Declaration

This PR was written by Claude Code (Claude Sonnet 5) under my direction, summarizing work from the same session that implemented and landed #111/#112/#113 (which I reviewed and merged myself).

  • I reviewed the added text against the actual merged PRs it describes.
  • The specific claims here (the client-secret/JWK conflict, the provider:write/provider:update bug, the two-process gate) were independently verified during the session that authored them, not taken from PR descriptions alone.
  • I take responsibility for this being an accurate account of what M1 shipped and why.

Reviewer Focus

Whether the M1 writeup is pitched at the right level of detail for this file's existing style — dense enough to be useful, not so long it drowns the next section.

@changeset-bot

changeset-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 577de59

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

The doc still read "M1 is still open: #23, #24, #25" after all three
merged and closed epic #18. Replaced the stale line with a writeup
matching the file's existing density: what each PR actually built, the
client-secret-vs-private_key_jwt schema conflict caught and resolved in
permission-literal bug Lightbridge caught in #24, and #25's two-genuinely-
separate-OS-processes acceptance gate.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@stephane-segning
stephane-segning force-pushed the claude/ticket-filtering-773c5c branch from 577de59 to 898ce72 Compare August 3, 2026 14:14
@stephane-segning
stephane-segning merged commit 9b01092 into main Aug 3, 2026
4 checks passed
@stephane-segning
stephane-segning deleted the claude/ticket-filtering-773c5c branch August 3, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant