Skip to content

WASD cam tweaks#709

Open
mhusinsky wants to merge 1 commit into
vvvv:mainfrom
mhusinsky:WASD_cam_tweaks
Open

WASD cam tweaks#709
mhusinsky wants to merge 1 commit into
vvvv:mainfrom
mhusinsky:WASD_cam_tweaks

Conversation

@mhusinsky

Copy link
Copy Markdown
Contributor

Following some discussion here with @jhnnslmk, some proposals to change camera behaviour wrt the mousewheel:

  • mousewheel dollies in/out (instead of changing FoV)
    • this is in line with the behaviour of Unity's and Unreal's camera
    • movement should have a priority over changing FoV
    • changing FoV should have a modifier key, therefore ...
  • CTRL+mousewheel changes FoV
    • this is also the behaviour of the OrbitCamera
  • rightclick/hold + mousewheel changes movement speed
    • same behaviour as in Unity and Unreal and makes sense
    • note: i left the Shift modifier also in and it acts as a multiplier now (i.e. holding Shift while moving multiplies current speed by a factor). this is similar to Unity's behaviour

to me this feels quite alright, as muscle memory from unity/unreal still applies.
opinions?

one thing still bothers me:

  • dollying forward by turning mouse wheel forward feels totally natural
  • adding the CTRL key + mouse wheel changes FoV in the opposite visual direction (ie. FoV widens, but it should zoom in). this is however the same as for the OrbitCam. we therefore have the dilemma that, CTRL+mousewheel should be inversed, but then it would not behave like the OrbitCam. i feel tempted to ask if we could therefore change the behaviour of the OrbitCam?

opinions?

- mousewheel dollies in/out
- CTRL+mousewheel changes FoV
- rightclick/hold + mousewheel changes movement speed
@antongit

Copy link
Copy Markdown
Member

Hi @mhusinsky,

sorry for super late. We've reviewed your pullrequest and it looks good for us.
Note, there is a conflict.
The reason is, that the nodes WASDCameraLogic and WASDCameraControls are in the VL.Stride.Cameras.vl > Advanced.
(for reviewing your request i've quickly moved the nodes around, so that we have a working version).
Would be great if you could start from main and reapply the changes.
Then we will merge the request.

As for "mouse wheel changes FoV in the opposite visual direction" changes - let's treat it as a separate topic to discuss after this PR is merged.

Thank you!
Anton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants