Skip to content

chore: fix sprite id type#52

Open
Max-0n wants to merge 1 commit into
vueuse:mainfrom
Max-0n:fix-types
Open

chore: fix sprite id type#52
Max-0n wants to merge 1 commit into
vueuse:mainfrom
Max-0n:fix-types

Conversation

@Max-0n

@Max-0n Max-0n commented Jan 9, 2025

Copy link
Copy Markdown

Sprite ID's uses string type

const { play } = useSound('/path/to/sprite.mp3', {
  sprite: {
    laser: [0, 300],
    explosion: [1000, 300],
    meow: [2000, 75],
  },
})

My commit fix type issue while call play cb

play({ id: 'kick' })

@Max-0n Max-0n changed the title Fix sprite id types chore: fix sprite id types Jan 9, 2025
@Max-0n Max-0n changed the title chore: fix sprite id types chore: fix sprite id type Jan 9, 2025
@QkeleQ10

QkeleQ10 commented Feb 2, 2025

Copy link
Copy Markdown

@Tahul Please implement, this tiny error upsets my TypeScript

@Max-0n

Max-0n commented Dec 1, 2025

Copy link
Copy Markdown
Author

@ThatOneCalculator i can't merge this fix... pls, do it by yourself

@ThatOneCalculator

Copy link
Copy Markdown

@Max-0n I can't merge either

@Max-0n

Max-0n commented Dec 1, 2025

Copy link
Copy Markdown
Author

why not? what i should to to to merge it?

@ThatOneCalculator

Copy link
Copy Markdown

......because I don't belong to this project?? I literally do not have permission to merge it.

@QkeleQ10

QkeleQ10 commented Dec 1, 2025

Copy link
Copy Markdown

Not sure why you are all pinging each other - neither of you would have merge permissions. This is @Tahul 's job, but I don't think this is being maintained anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants