Move dfa cache in scan data - #264
Open
vthib wants to merge 3 commits into
Open
Conversation
Instead of storing the DFA caches in the matchers in a thread local pool, store them in the ScanData, forcing recreation on new scan, and drop at the end. This replaces caches that could only grow, with multiple versions per thread, with temporary memory that is released after the scan ends. Performance wise, it is unclear how much this has an impact.
Removing the Arc around the DFA made the validator size explode. Box it to ensure it does make the HalfValidator & Validator enums huge because of this single element.
Instead of duplicating the handling of the reverse matches in each validator branch, use an intermediary object so that this logic is not duplicated and does not risk drifting.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #264 +/- ##
=======================================
Coverage 98.31% 98.31%
=======================================
Files 94 94
Lines 26938 26981 +43
=======================================
+ Hits 26483 26526 +43
Misses 455 455 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of storing the DFA caches in the matchers in a thread local pool, store them in the ScanData, forcing recreation on new scan, and drop at the end.
This replaces caches that could only grow, with versions per thread, with temporary memory that is
released after the scan ends. Performance wise, it is unclear how much this has an impact. The cache is no longer shared between scans, but scans may not need the same caching. Redoing some benchmarks would be useful.