Skip to content

fix(tools): add all config properties to sessionQuestionSchema and push_question #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vistar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tools): add all config properties to sessionQuestionSchema and push_question #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 39 additions & 9 deletions src/tools/octto/factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,15 +60,50 @@ const QUESTION_TYPE_ENUM = [
"emoji_react",
] as const;

/** All config properties as .any().optional() so looseObject passes them through Zod parsing. */
const pushQuestionConfigSchema = tool.schema
.looseObject({
question: tool.schema.string().optional(),
context: tool.schema.string().optional(),
options: tool.schema.any().optional(),
min: tool.schema.any().optional(),
max: tool.schema.any().optional(),
step: tool.schema.any().optional(),
recommended: tool.schema.any().optional(),
allowOther: tool.schema.any().optional(),
allowFeedback: tool.schema.any().optional(),
allowCancel: tool.schema.any().optional(),
defaultValue: tool.schema.any().optional(),
labels: tool.schema.any().optional(),
emojis: tool.schema.any().optional(),
yesLabel: tool.schema.any().optional(),
noLabel: tool.schema.any().optional(),
before: tool.schema.any().optional(),
after: tool.schema.any().optional(),
filePath: tool.schema.any().optional(),
language: tool.schema.any().optional(),
content: tool.schema.any().optional(),
sections: tool.schema.any().optional(),
markdown: tool.schema.any().optional(),
placeholder: tool.schema.any().optional(),
multiline: tool.schema.any().optional(),
minLength: tool.schema.any().optional(),
maxLength: tool.schema.any().optional(),
accept: tool.schema.any().optional(),
multiple: tool.schema.any().optional(),
maxImages: tool.schema.any().optional(),
maxFiles: tool.schema.any().optional(),
maxSize: tool.schema.any().optional(),
})
.describe("Question configuration (varies by type)");

function executePushQuestion(
sessions: SessionStore,
args: { session_id: string; type: QuestionType; config: BaseConfig },
): string {
try {
const pushed = sessions.pushQuestion(args.session_id, args.type, args.config);
return `Question pushed: ${pushed.question_id}
Type: ${args.type}
Use get_next_answer(session_id, block=true) to wait for the user's response.`;
return `Question pushed: ${pushed.question_id}\nType: ${args.type}\nUse get_next_answer(session_id, block=true) to wait for the user's response.`;
} catch (error) {
return `Failed to push question: ${extractErrorMessage(error)}`;
}
Expand All @@ -81,12 +116,7 @@ The question will appear in the browser for the user to answer.`,
args: {
session_id: tool.schema.string().describe("Session ID from start_session"),
type: tool.schema.enum(QUESTION_TYPE_ENUM).describe("Question type"),
config: tool.schema
.looseObject({
question: tool.schema.string().optional(),
context: tool.schema.string().optional(),
})
.describe("Question configuration (varies by type)"),
config: pushQuestionConfigSchema,
},
execute: async (args) => executePushQuestion(sessions, args),
});
Expand Down
29 changes: 29 additions & 0 deletions src/tools/octto/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,35 @@ const sessionQuestionSchema = tool.schema
.looseObject({
question: tool.schema.string().optional(),
context: tool.schema.string().optional(),
options: tool.schema.any().optional(),
min: tool.schema.any().optional(),
max: tool.schema.any().optional(),
step: tool.schema.any().optional(),
recommended: tool.schema.any().optional(),
allowOther: tool.schema.any().optional(),
allowFeedback: tool.schema.any().optional(),
allowCancel: tool.schema.any().optional(),
defaultValue: tool.schema.any().optional(),
labels: tool.schema.any().optional(),
emojis: tool.schema.any().optional(),
yesLabel: tool.schema.any().optional(),
noLabel: tool.schema.any().optional(),
before: tool.schema.any().optional(),
after: tool.schema.any().optional(),
filePath: tool.schema.any().optional(),
language: tool.schema.any().optional(),
content: tool.schema.any().optional(),
sections: tool.schema.any().optional(),
markdown: tool.schema.any().optional(),
placeholder: tool.schema.any().optional(),
multiline: tool.schema.any().optional(),
minLength: tool.schema.any().optional(),
maxLength: tool.schema.any().optional(),
accept: tool.schema.any().optional(),
multiple: tool.schema.any().optional(),
maxImages: tool.schema.any().optional(),
maxFiles: tool.schema.any().optional(),
maxSize: tool.schema.any().optional(),
})
.describe("Question config (varies by type)"),
}),
Expand Down