Implement Basic SDF Boolean Example - #14
Conversation
nixonyh
left a comment
nixonyh
left a comment
There was a problem hiding this comment.
Looks good overall! Would love to have the comments addressed. Do you have a screenshot to paste it in this PR? Thanks.
|
I think @Sheerwin02 brought up that there was some issues with intersections right? Perhaps @Sheerwin02 you could simplify the examples to just 2 spheres for now. That would make it easier to determine what's what. |
|
|
||
| // Boolean operations for grouping primitives. | ||
| const OP_UNION: u32 = 0u; | ||
| const OP_DIFFERENCE: u32 = 1u; |
There was a problem hiding this comment.
| const OP_DIFFERENCE: u32 = 1u; | |
| const OP_SUBTRACTION: u32 = 1u; |
Can we rename this?
There was a problem hiding this comment.
I think difference would be a more suitable name, in my opinion.
| #[derive(Debug, Clone, Copy, PartialEq, Eq, Reflect)] | ||
| pub enum BooleanOp { | ||
| Union = 0, | ||
| Difference = 1, |
There was a problem hiding this comment.
| Difference = 1, | |
| Subtraction = 1, |
nixonyh
left a comment
nixonyh
left a comment
There was a problem hiding this comment.
Clean, once the screenshot is updated (to confirm the various operations work) and the checks pass, we can merge this :)
I had updated the screenshot, you guys can verify is the output accurate. |
|
Looks correct! Union was not in the demo, but we had verified that it works previously. |
3 participants
This is the uploaded screenshot.
Fix #13