fix: hot-reload throw path contains backslash in windows - #75
fix: hot-reload throw path contains backslash in windows#75moe-moe-pupil wants to merge 1 commit into
Conversation
fix Failed to load asset 'typst\client\in_lobby.typ' with asset loader 'velyst::asset::VelystSourceLoader': path contains backslash bc in windows, load_context.path().to_string() returns a path string with "\\"
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe asset loader now converts backslashes in Typst loader paths to forward slashes before constructing the ChangesAsset loader path normalization
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Oo, I think we had similar issue last time with voxell-tech/motiongfx#38 May be worth referencing. |
thanks for quick reply, but i think it's different, in my case, the |
|
I see, I'll take a look in testing this to make sure it works in other os-es too. Thanks for this PR! |
Why
im facing an issue for hot-reload in windows, Failed to load asset 'typst\client\in_lobby.typ' with asset loader 'velyst::asset::VelystSourceLoader': path contains backslash
bc in windows, load_context.path().to_string() returns a path string with "\"
Testing
i only test it on my windows pc, it works well for me