Move id generator into typarena

[nixonyh]

No description provided.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0e1cede1-44ab-44c2-8b42-a4665af93447

📥 Commits

Reviewing files that changed from the base of the PR and between 7e75a94 and 1495d3f.

📒 Files selected for processing (4)

• crates/fynix/src/lib.rs
• crates/fynix/src/style.rs
• crates/typarena/src/id.rs
• crates/typarena/src/lib.rs

💤 Files with no reviewable changes (1)

• crates/fynix/src/lib.rs

---

📝 Walkthrough

Summary by CodeRabbit

• Refactor

  • Updated internal identifier handling to use a shared implementation, improving consistency across the crate.
  • Kept the public API unchanged.

• Documentation

  • Expanded comments to better explain how generational IDs work and how they prevent accidental ID mix-ups.

Walkthrough

The internal id module is removed from the fynix crate, and typarena now publicly exposes its own id module with additional documentation. fynix's style.rs updates its imports to source GenId and IdGenerator from typarena::id instead of crate::id.

Changes

ID Module Relocation

Layer / File(s)	Summary
Expose typarena's id module crates/typarena/src/lib.rs, crates/typarena/src/id.rs	Adds pub mod id; declaration and expands doc comments describing generational ID purpose and type-level domain isolation.
Switch fynix to typarena's id types crates/fynix/src/lib.rs, crates/fynix/src/style.rs	Removes fynix's internal mod id; declaration and updates style.rs imports so StyleId/StyleIdGenerator are backed by typarena::id::GenId/IdGenerator.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: ian-hon

Poem

A hop, a skip, an id set free,
From fynix's den to typarena's tree.
Docs now bloom where types once hid,
No more clash 'twixt id and id!
🐇✨ Onward to cleaner code we flee.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No description was provided, so there is nothing to assess beyond the code changes.	Add a brief description of what was moved and why, such as the new typarena re-export and the fynix import change.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title matches the main change: the ID generator is being moved into the typarena crate.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}