vos record reads the hosted recording cap live - #128
Merged
Conversation
The cap a take records under is --max-duration when given; else the platform's public GET /api/limits, asked with the caller's key when one resolves so a plan with a longer cap gets it; else the built-in 30 minutes, said in words, because a take longer than the platform's cap is refused at push time. Bounded at two seconds and fail-open, so an offline machine records exactly as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vos recordandvos createstop a take at the hosted recording cap so what lands is what the platform hosts. Until now that cap was a constant here, and a change on the platform meant a CLI release.The cap is now resolved once before each take:
--max-durationwhen given; else the platform's publicGET /api/limits(limits.recordingMaxSeconds), asked with the caller's key when one resolves so a plan with a longer cap gets it; else the built-in 30 minutes, said in a note, because a take longer than the platform's cap is refused at push time. The read is bounded at two seconds and fail-open, so an offline machine records exactly as before.parseHostedCaprefuses any payload that is not a limits table.Verified:
pnpm check,pnpm typecheck,pnpm lint,pnpm testgreen (cli 192).