fix(package): repair moved global bin symlinks#2104
Open
fordlyn wants to merge 1 commit intovolta-cli:mainfrom
Open
fix(package): repair moved global bin symlinks#2104fordlyn wants to merge 1 commit intovolta-cli:mainfrom
fordlyn wants to merge 1 commit intovolta-cli:mainfrom
Conversation
Repair Unix package bin symlinks after moving a global package install from the staging directory into the final package image directory. Some packages rewrite npm global bin entries during postinstall to point at absolute paths inside the staging directory. After Volta persists that directory into tools/image/packages, those symlinks become stale and the generated Volta shim fails to execute. Only symlinks in the package bin directory that point back into the staging directory are rewritten. Regular files, relative symlinks, and external symlinks are left unchanged. Also clear _VOLTA_TOOL_RECURSION in test sandboxes so smoke and acceptance tests do not accidentally inherit a parent shim-recursion state. Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repair Unix package bin symlinks after moving a global package install from the staging directory into the final package image directory.
Some packages rewrite npm global bin entries during postinstall to point at absolute paths inside the staging directory. After Volta persists that directory into tools/image/packages, those symlinks become stale and the generated Volta shim fails to execute.
Only symlinks in the package bin directory that point back into the staging directory are rewritten. Regular files, relative symlinks, and external symlinks are left unchanged.
Also clear _VOLTA_TOOL_RECURSION in test sandboxes so smoke and acceptance tests do not accidentally inherit a parent shim-recursion state.