chore: update Go toolchain to 1.26.4#391
Conversation
Signed-off-by: ranxi2001 <ranxi169@163.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Go version across the project to 1.26.4. This includes updating the Go version in go.mod and upgrading the builder images in docker/Dockerfile, docker/Dockerfile.picod, and docker/Dockerfile.router to use Go 1.26.4. I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Pull request overview
Updates AgentCube’s Go toolchain baseline to Go 1.26.4 and reduces CI version drift by making GitHub Actions read the Go version directly from go.mod. This aligns local builds, CI, and Docker builder images on the same Go patch version.
Changes:
- Bump
go.modGo version to 1.26.4 and remove the oldtoolchain go1.24.9pin. - Update GitHub Actions workflows to use
actions/setup-gowithgo-version-file: go.modinstead of hard-coded versions. - Update Docker builder base images for workload manager, router, and picod to golang:1.26.4 (matching the module baseline).
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates the module’s Go version baseline to 1.26.4 and removes the old toolchain pin. |
| docker/Dockerfile | Updates workload manager builder image to Go 1.26.4. |
| docker/Dockerfile.router | Updates router builder image to Go 1.26.4. |
| docker/Dockerfile.picod | Updates picod builder image to Go 1.26.4. |
| .github/workflows/test-coverage.yml | Switches CI Go setup to read version from go.mod. |
| .github/workflows/lint.yml | Switches CI Go setup to read version from go.mod. |
| .github/workflows/e2e.yml | Switches CI Go setup to read version from go.mod. |
| .github/workflows/codegen-check.yml | Switches CI Go setup to read version from go.mod. |
| .github/workflows/build-push-release.yml | Switches release workflow Go setup to read version from go.mod. |
| - name: Set up Go | ||
| uses: actions/setup-go@v4 | ||
| with: | ||
| go-version: "1.24.4" | ||
| go-version-file: go.mod |
There was a problem hiding this comment.
Thanks for the suggestion.
I agree that updating the Node16-based actions is useful, but I would prefer to keep this PR focused on the Go toolchain update and Go version source-of-truth cleanup. The existing CI for this PR
has passed, and changing the action runtime versions feels like a separate workflow modernization item.
I can follow up with a separate cleanup PR for actions/checkout / actions/setup-go version updates if maintainers think that should be handled independently.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #391 +/- ##
===========================================
+ Coverage 47.57% 57.96% +10.39%
===========================================
Files 30 34 +4
Lines 2819 3181 +362
===========================================
+ Hits 1341 1844 +503
+ Misses 1338 1153 -185
- Partials 140 184 +44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RainbowMango
left a comment
RainbowMango
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Good job! Thanks.
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR updates AgentCube's Go toolchain baseline to Go 1.26.4.
It also reduces future Go version drift in GitHub Actions by making Go setup read from
go.modviago-version-file: go.mod, instead of hard-coding separate Go versions in individual workflows.Docker builder images are updated to the same Go patch version because Dockerfiles cannot read
go.modautomatically.Which issue(s) this PR fixes:
Refs #386
Special notes for your reviewer:
Scope:
go.modtogo 1.26.4.toolchain go1.24.9line after runninggo mod tidywith the target Go version.go-version-file: go.mod.Validation:
Check for spelling errors,Codegen Check,Python Lint, twobuildchecks,coverage,e2e-test,golangci-lint, andpython-sdk-tests.Local validation:
go list ./... | grep -v '^github.com/volcano-sh/agentcube/test/e2e$' | xargs go test -count=1go test -race -v -coverprofile=coverage.out -coverpkg=./pkg/... ./pkg/...make build-allmake lintmake gen-checkdocker build -f docker/Dockerfile -t agentcube-go1264-workloadmanager:test .docker build -f docker/Dockerfile.router -t agentcube-go1264-router:test .docker build -f docker/Dockerfile.picod -t agentcube-go1264-picod:test .git diff --checkAI assistance:
Does this PR introduce a user-facing change?: