fix(cache): prevent unreadable oversized fingerprints#553
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Co-authored-by: GPT-5.6 Codex <codex@openai.com>
wan9chi
force-pushed
the
agent/bump-wincode-0.6
branch
from
July 21, 2026 02:58
4ef4422 to
32279ad
Compare
wan9chi
marked this pull request as ready for review
July 21, 2026 03:05
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32279ad85b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
wincode 0.5.2 enforced its default preallocation limit when deserializing dynamic maps but not when serializing them. A large inferred-input fingerprint could therefore be persisted successfully and then fail on the next cache lookup with
Encoded sequence length exceeded preallocation limit, leaving a cache entry that its writer could not read back.Changes
This preserves the 4 MiB preallocation policy while preventing oversized fingerprints from poisoning later cache lookups. Formatting, workspace checks, default tests, Clippy, and rustdoc pass locally.