Bump Go toolchain to 1.26.4 and golang.org/x/crypto to v0.53.0#318
Open
ggverma wants to merge 1 commit into
Open
Bump Go toolchain to 1.26.4 and golang.org/x/crypto to v0.53.0#318ggverma wants to merge 1 commit into
ggverma wants to merge 1 commit into
Conversation
go.mod's `go` directive was 1.23.1 (now EOL), and since no explicit `toolchain` line overrides it, Go's toolchain auto-management (GOTOOLCHAIN=auto) uses that exact version during the build - as confirmed by the actual embedded build version in the shipped operator binary (`go1.23.1`), regardless of whatever Go version is pre-installed in the build environment. Bumping the directive to 1.26.4 is sufficient on its own (fixes CVE-2025-68121, CVE-2026-27143): verified locally that `go build ./cmd/manager` with this change auto-downloads and uses go1.26.4. Also bump golang.org/x/crypto v0.36.0 -> v0.53.0 (`go get -u golang.org/x/crypto@v0.53.0 && go mod tidy`, pulling x/net, x/sys, x/term, x/text along for the ride). The 7 CVEs BlackDuck flagged against v0.36.0 are all in x/crypto's ssh/ssh-agent/knownhosts packages, none of which this operator imports (`go list -deps` confirms), so this is hygiene rather than a real fix - but it's low-risk and clears the scan. Verified: `go build ./cmd/manager` succeeds, `go vet ./...` shows only the same 4 pre-existing unrelated test-file lint warnings as before this change. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go.mod's
godirective was 1.23.1 (now EOL), and since no explicittoolchainline overrides it, Go's toolchain auto-management (GOTOOLCHAIN=auto) uses that exact version during the build - as confirmed by the actual embedded build version in the shipped operator binary (go1.23.1), regardless of whatever Go version is pre-installed in the build environment. Bumping the directive to 1.26.4 is sufficient on its own (fixes CVE-2025-68121, CVE-2026-27143): verified locally thatgo build ./cmd/managerwith this change auto-downloads and uses go1.26.4.Also bump golang.org/x/crypto v0.36.0 -> v0.53.0 (
go get -u golang.org/x/crypto@v0.53.0 && go mod tidy, pulling x/net, x/sys, x/term, x/text along for the ride). The 7 CVEs BlackDuck flagged against v0.36.0 are all in x/crypto's ssh/ssh-agent/knownhosts packages, none of which this operator imports (go list -depsconfirms), so this is hygiene rather than a real fix - but it's low-risk and clears the scan.Verified:
go build ./cmd/managersucceeds,go vet ./...shows only the same 4 pre-existing unrelated test-file lint warnings as before this change.