Fix networkDiagnostics validation failure with Server-Side Apply#316
Merged
Conversation
Remove 'spec' field from the apply configuration so that the operator only applies status/metadata changes. This avoids schema validation failures on uninitialized 'spec.networkDiagnostics' fields introduced in newer OpenShift versions (4.16+). Co-authored-by: Cursor <cursoragent@cursor.com>
dantingl
approved these changes
Jul 21, 2026
heypnus
approved these changes
Jul 21, 2026
Contributor
|
I had a quick chat with Xiao about this patch. Due to environment and time constraints, it hasn't been run through e2e tests yet. However, given its limited potential side effects, we decided to merge it first to speed up follow-up validation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an issue where the
nsx-ncp-operatordegrades on OpenShift due to an OpenAPI schema validation mismatch with newer OpenShift versions (OCP 4.16+).Even though the
managedFieldsissue was resolved, when the operator's configmap-controller (updateNetworkStatus) attempts to patch theNetwork.config.openshift.ioresource, it serializes empty nested fields of thenetworkDiagnosticsstruct as JSON null values. The OpenShift API server's CRD validation strictly prohibitsnullfor these fields (expecting objects or arrays).To fix this, we remove the
specfield from the apply configuration so that the operator only applies status/metadata changes, avoiding schema validation failures on uninitializedspec.networkDiagnosticsfields.Test plan
go build -o /dev/null ./cmd/managersucceeds.Made with Cursor