Move .dockerignore to the repo root so it is actually read - #314
Merged
Conversation
Signed-off-by: ronenkat <16743404+ronenkat@users.noreply.github.com>
ronenkat
requested review from
hsliuustc0106 and
jiangkuaixue123
as code owners
September 5, 2026 09:27
Collaborator
|
Thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Move
docker/.dockerignoreto the repo root so it is actually read.Both the CI build (
.buildkite/cuda/scripts/build-ci-image.sh) and any buildfrom the repo root use the repo root as the build context and pass the
Dockerfile with
--file docker/Dockerfile.ci. Builders read only.dockerignoreat the context root (or the BuildKit-only<dockerfile>.dockerignore), sodocker/.dockerignorehas never had anyeffect and none of its patterns are enforced.
Issue
docker/.dockerignoreis not observed when building the image #313docker/.dockerignoreis not observed when building the image #313Scope
docker/Dockerfile.ci.Implementation Notes
No impact on code. The context root is the only
location honored by BuildKit, the classic builder and buildah alike, so this
fixes CI and repo-root builds with one change.
Test Plan
Build from the repo root with the CI invocation shape
(
--file docker/<dockerfile> .) before and after the move, and inspect thebuilt image rather than trusting the ignore file.
Test Result
Identical commands; only the ignore file's location differed:
.git.DS_Storedocker/.dockerignore--ignorefile docker/.dockerignore).dockerignore(repo root)The control build points
--ignorefileat the same file and the patterns takeeffect, confirming the contents were always valid and only the location was
wrong.
Independently, the shipped CI image
public.ecr.aws/q9t5s3a7/vllm-ci-test-repo:22afe58…(source layersha256:de75870e…) containsopt/afd-plugin/.git, confirming the same defectin CI.
Docs Impact