Update run-e2e skill fixing inconsistencies for the Qwen suite - #306
Conversation
Signed-off-by: ronenkat <16743404+ronenkat@users.noreply.github.com>
jiangkuaixue123
left a comment
There was a problem hiding this comment.
The topology correction matches the Qwen suites, and the HF_ENDPOINT guidance matches gsm8k.py. Two remaining passages should be aligned with the corrected scope.
| leaving the fourth device idle. For DeepSeek-V2-Lite these are local-only | ||
| cases; for Qwen3 MoE and Qwen3.6 MoE they are the suite's gate scenarios. | ||
|
|
||
| Tests run sequentially and must not skip. Every GSM8K evaluation uses 8 |
There was a problem hiding this comment.
Please also update the “Local 2A1F cases” section below (lines 94–98). It still says all 2 Attention + 1 FFN scenarios are local-only and that CI gates do not run them, which contradicts the Qwen gate scope clarified here. Qualify both the heading and that sentence as DeepSeek-V2-Lite-specific, e.g. “The DeepSeek-V2-Lite 2A1F scenarios are local-only; its CI gate selects the 2A2F scenarios.”
| `baseline-graph` uses native DP4/TP1/EP4. The 2A1F cases (`afd-eager-2a1f`, | ||
| `afd-graph-2a1f`, `afd-graph-dbo-2a1f`) use 2 Attention ranks and 1 FFN rank; | ||
| for DeepSeek-V2-Lite they are local-only scenarios, while for Qwen3 MoE and | ||
| Qwen3.6 MoE they are the suite's gate scenarios. |
There was a problem hiding this comment.
Please also align the device-order paragraph below (lines 89–90), which still calls these “The local 2A1F scenarios.” Since this skill covers Qwen suites whose gate scenarios use this same topology, remove “local” there or explicitly qualify it as DeepSeek-V2-Lite-only. This will keep the execution guidance consistent with the corrected scope here.
Signed-off-by: ronenkat <16743404+ronenkat@users.noreply.github.com>
Thank you for the feedback. Text updated. |
PLEASE FILL IN THE PR DESCRIPTION AND MAKE SURE THE CHECKLIST ITEMS HAVE BEEN CONSIDERED.
Purpose
topology belong to DeepSeek-V2-Lite only; the Qwen3 MoE and Qwen3.6 suites
are baseline-graph plus three 2A1F scenarios, which use the first two
devices for Attention and the third for FFN and leave the fourth idle.
Apply the same correction to the opening paragraph of
tests/e2e/README.md.
reference table, with the reason: gsm8k.py defaults the lm-eval child to
hf-mirror.com, so an unreachable mirror is not visible until GSM8K starts,
with the servers already up.
Issue
run-e2eskill misstates the Qwen suite topology and omits theHF_ENDPOINTprerequisite #305run-e2eskill misstates the Qwen suite topology and omits theHF_ENDPOINTprerequisite #305Scope
Implementation Notes
None
Test Plan
N/A
Test Result
N/A
Docs Impact
Essential PR Checklist