Narrow the findUsers result to a minimal UserListItem type - #6219
Open
fraxachun wants to merge 1 commit into
Open
Narrow the findUsers result to a minimal UserListItem type#6219fraxachun wants to merge 1 commit into
fraxachun wants to merge 1 commit into
Conversation
nsams
reviewed
Aug 20, 2026
| throw new Error("For this functionality you need to define `findUserOrThrow` (or the deprecated `getUser`) in the userService."); | ||
| } | ||
|
|
||
| async findUsers(args: FindUsersArgs): Promise<[User[], number]> { |
Member
There was a problem hiding this comment.
findUsers and findUserOrThrow should return the same type. Having to call findUserOrThrow to get a "fullUser" is confusing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some UserServices might provide an enhanced User type with additional information which can be useful in projects. However, in the findUsers-Request for performance reasons the additional information should not be mandatory.
Solution
This PR makes it possible for a UserService to implement this behaviour by only require the core User fields in findUsers().