Rework the dextinity-admin-ui skill's prose and description - #6214
Open
VPS-Ricky wants to merge 6 commits into
Open
Rework the dextinity-admin-ui skill's prose and description#6214VPS-Ricky wants to merge 6 commits into
VPS-Ricky wants to merge 6 commits into
Conversation
The skill grew one section per pull request, and none revisited the sections before it.
The deprecation behind the Button rule is in the package source, not in the skill, so a reader had no way to check it.
The description is the whole trigger, and nothing in the body can help a skill load, so a section the description does not reach is dead weight.
Removing the metaphor "blur together" reversed the sentence: it argued that mixing sx into markup puts layout, styling, and logic in one place, which two other sections give as a reason to use styled().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The skill grew one section per pull request, and none revisited the sections before it, so the prose was never read end to end.