Make base classes abstract#282
Open
AnAvailableName wants to merge 4 commits into
Open
Conversation
AnAvailableName
force-pushed
the
make-base-classes-abstract
branch
from
24ab512 to
b32139e
Compare
larsk21
requested changes
Jun 22, 2026
| // This is because eMoflon::neo gives us these parameters based on the index in the invocation, which | ||
| // can be different than the index in the definition. And of course, we don't get the name of the parameter. | ||
| // This is because eMoflon::neo gives us these parameters based on the index in | ||
| // the invocation, which |
Member
There was a problem hiding this comment.
Unnecessary like break in L32 (very short line).
| @Override | ||
| public String toString() { | ||
| var params = parameters.stream().map(param -> param.attribute() + ": " + param.value()).collect(Collectors.joining(",")); | ||
| var params = parameters.stream().map(param -> param.attribute() + ": " + param.value()) |
Member
There was a problem hiding this comment.
If you break a stream expression, I would switch to a style where all stream methods are in their own line, i.e.
.stream()
.map(...)
.collect(...)
| .vscode/ | ||
|
|
||
| ### Metals lsp ### | ||
| **/.metals/ |
Member
There was a problem hiding this comment.
The double asterisks are unnecessary here.
Collaborator
Author
There was a problem hiding this comment.
It has actually crated folders in lang/frontend and lang/ however maybe it was due to a misconfiguration on my part. For now I have removed the asterisks (and added one folder that I forgot).
AnAvailableName
force-pushed
the
make-base-classes-abstract
branch
from
55c96cd to
fd042a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.