closes #141: Change name of implicit root containments#267
Open
AnAvailableName wants to merge 3 commits into
Open
closes #141: Change name of implicit root containments#267AnAvailableName wants to merge 3 commits into
AnAvailableName wants to merge 3 commits into
Conversation
AnAvailableName
force-pushed
the
change-name-of-implicit-root-containments
branch
from
bdcd7fc to
e55924e
Compare
larsk21
requested changes
Jun 22, 2026
| <maven.compiler.release>17</maven.compiler.release> | ||
| <maven.compiler.source>17</maven.compiler.source> | ||
| <maven.compiler.target>17</maven.compiler.target> | ||
| <kotlin.version>2.3.10</kotlin.version> |
Collaborator
Author
There was a problem hiding this comment.
Sorry I have not added it. I suppose it was added automatically for some reason and I added a folder to git without carefully checking it.
|
|
||
| public class Formatting { | ||
|
|
||
| public static String formatRootReferenceName(String name) { |
Member
There was a problem hiding this comment.
As this is a public utility function, I would add a JavaDoc comment, explaining, e.g., that the name argument may not be null or empty.
Collaborator
Author
There was a problem hiding this comment.
Yes I added it.
AnAvailableName
force-pushed
the
change-name-of-implicit-root-containments
branch
from
b2a7985 to
99a662e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.