Add dependency analysis features#910
Open
AndreaKe wants to merge 15 commits into
Open
Conversation
AndreaKe
force-pushed
the
keuscha/dependency_analysis_refactoring
branch
from
May 26, 2026 13:35
0f67b51 to
e720345
Compare
marcoeilers
approved these changes
May 27, 2026
marcoeilers
left a comment
marcoeilers
left a comment
Contributor
There was a problem hiding this comment.
One comment and one question, otherwise LGTM
AndreaKe
force-pushed
the
keuscha/dependency_analysis_refactoring
branch
2 times, most recently
from
July 8, 2026 13:32
b3e9343 to
e769a34
Compare
AndreaKe
force-pushed
the
keuscha/dependency_analysis_refactoring
branch
from
July 8, 2026 13:39
e769a34 to
7b55f01
Compare
jcp19
reviewed
Jul 13, 2026
jcp19
left a comment
jcp19
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but I think there are ways to make the code more maintainable in the long run.
Also, I just glanced over src/main/scala/viper/silver/parser/Translator.scala, looks OK but I did not look at it very closely
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds features required to support the verification dependency analysis. In particular, each AST node is associated with a dependency type and its source (stored in the info field).