ci: bump lock-threads to v6 so the scheduled lock job can run - #9221
Open
tushardev-365 wants to merge 1 commit into
Open
ci: bump lock-threads to v6 so the scheduled lock job can run#9221tushardev-365 wants to merge 1 commit into
tushardev-365 wants to merge 1 commit into
Conversation
The pinned version validates its github-token input with a 100 character cap, and the Actions token now exceeds that, so every run fails before locking anything: ##[error]"github-token" length must be less than or equal to 100 characters long This workflow does not pass github-token itself, but the action declares default: github.token in action.yml, so the default is substituted and validated all the same. v6 raised the cap to 1000 (v4 and v5.0.x both still validate max(100)). Every input this workflow passes exists unchanged in the v6 schema, so the pin bump is the whole fix. Pinned to the v6.0.2 release commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduled lock job fails on every run before locking anything. The last 10 runs of
lock.ymlare all failures, each with:(from run 32324081534; the earlier runs fail identically)
The workflow pins
dessant/lock-threads@v4, and that version validates itsgithub-tokeninput with a 100 character cap in its Joi schema:The Actions token has grown past 100 characters, so validation rejects it and the action exits before doing any work. The cap raise landed in v6.0.2 specifically: v4, v5.0.x, v6.0.0 and v6.0.1 all still validate
max(100), and v6.0.2 moved it to 1000. So v6.0.2 is the first safe pin, and it is what the movingv6tag currently points at.Worth noting since it is the first thing one might try: this workflow does not pass
github-tokenat all, but removing or not passing the input does not avoid the bug, because the action declaresdefault: ${{ github.token }}in itsaction.ymland the default goes through the same validation.I checked every input this workflow passes against the v6.0.2 schema and all of them exist there unchanged, including their accepted values, so the pin bump is the entire fix. The new pin is the commit the v6.0.2 release tag resolves to, keeping the SHA-pinned style.
I could not run this against the repo since the workflow only triggers on schedule, but the same one-line bump fixed the identical failure elsewhere, and the v6 cohort of repos running this action shows green runs.