Skip to content

Fix JSDoc param names that do not match the signatures - #9220

Open
darkdi wants to merge 1 commit into
videojs:mainfrom
darkdi:docs-param-names
Open

Fix JSDoc param names that do not match the signatures#9220
darkdi wants to merge 1 commit into
videojs:mainfrom
darkdi:docs-param-names

Conversation

@darkdi

@darkdi darkdi commented Aug 15, 2026

Copy link
Copy Markdown

Left two that the same check flags. Slider#handleMouseMove documents mouseDown because subclasses take it and the base is an empty stub, and removeRemoteTextTrack names its parameter obj but falls back to treating the whole argument as the track, so track reads closer to what callers actually pass.

@welcome

welcome Bot commented Aug 15, 2026

Copy link
Copy Markdown

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant