fix: add missing case in Dom.isSingleLeftClick for Mac trackpad - #9218
Closed
lynvortex wants to merge 1 commit into
Closed
fix: add missing case in Dom.isSingleLeftClick for Mac trackpad#9218lynvortex wants to merge 1 commit into
lynvortex wants to merge 1 commit into
Conversation
Fix #7736 On Mac trackpad, tapping may produce event with button=0 and buttons=1, which was not handled by isSingleLeftClick. Add explicit check for this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #7736
On Mac trackpad, tapping may produce mousedown event with button=0 and buttons=1,
which was not handled by isSingleLeftClick. This causes multiple taps needed to
interact with the seek bar and volume control.
Add explicit check for this case to return true.